From: Mike Frysinger <vapier@gentoo.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Binutils <binutils@sourceware.org>,
GDB <gdb-patches@sourceware.org>
Subject: Re: ping #3: [RFA] Add --with-libz-prefix option in config/zlib.m4
Date: Wed, 18 Feb 2015 16:55:00 -0000 [thread overview]
Message-ID: <20150218165457.GU544@vapier> (raw)
In-Reply-To: <CAMe9rOp9YQrhwwrmqRa+a-04BNvd+p9_MVgxkiVhgt+6TkDb7g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
On 18 Feb 2015 04:56, H.J. Lu wrote:
> On Wed, Feb 18, 2015 at 4:08 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> > On Wed, Jan 07, 2015 at 06:45:48PM +0400, Joel Brobecker wrote:
> >> This patch enhances config/zlib.m4 to introduce an extra option
> >> --with-libz-prefix which allows us to provide the location of
> >> the zlib library we want to use during the build.
> >>
> >> config/ChangeLog:
> >>
> >> * zlib.m4 (AM_ZLIB): Add --with-libz-prefix option support.
> >>
> >> I didn't see any file in the GCC project that uses this macro,
> >> so for the GCC repository, the change to zlib.m4 is it. But
> >> I am also attaching to this email a copy of the patch that
> >> will be applied to the binutils-gdb.git repository, with all
> >> configury using this macro being re-generated - mostly for info,
> >> also as a heads-up to both binutils and GDB.
> >>
> >> This was tested by regenerating all autoconf/automake files in
> >> the binutils-gdb project, and rebuilding GDB, using the following
> >> combinations:
> >>
> >> --with-zlib (system zlib used)
> >> --with-libz-prefix=/zlib/prefix (specific zlib linked in)
> >> --with-zlib --with-libz-prefix=/zlib/prefix (specific zlib linked in)
> >>
> >> --without-zlib (zlib support turned off)
> >> --without-zlib --with-zlib-prefix (zlib support turned off)
> >>
> >> --with-zlib (no system zlib available, configure fails with expected error)
> >> --with-zlib --with-libz-prefix=/invalid/zlib/prefix
> >> (no system zlib, configure fails with same error)
> >>
> >> OK to commit?
>
> Why do you want to turn off zlib? On Linux/x86, zlib is required
> for assembler. At least, you should issue an error when --without-libz
> is used in binutils for Linux/x86 target.
err, when did that happen ? why would zlib be possibly required for an
assembler ?
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-18 16:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 14:46 Joel Brobecker
2015-01-07 16:01 ` Tristan Gingold
2015-01-07 17:02 ` Joel Brobecker
2015-02-19 7:55 ` Thomas Schwinge
2015-02-19 7:58 ` Thomas Schwinge
2015-01-21 7:49 ` ping: " Joel Brobecker
2015-01-21 8:22 ` Tristan Gingold
2015-01-21 8:33 ` Joel Brobecker
2015-02-04 3:57 ` ping^2: " Joel Brobecker
2015-02-18 12:09 ` ping #3: " Joel Brobecker
2015-02-18 12:56 ` H.J. Lu
2015-02-18 16:55 ` Mike Frysinger [this message]
2015-02-18 16:58 ` H.J. Lu
2015-02-18 19:44 ` Mike Frysinger
2015-02-18 19:52 ` H.J. Lu
2015-02-18 20:32 ` Mark Wielaard
2015-02-18 20:42 ` Jakub Jelinek
2015-02-18 20:53 ` H.J. Lu
2015-02-18 21:54 ` Mark Wielaard
2015-02-18 22:03 ` H.J. Lu
2015-02-18 22:21 ` Mike Frysinger
2015-02-18 22:24 ` H.J. Lu
2015-02-18 23:10 ` Mike Frysinger
2015-02-19 7:17 ` Mark Wielaard
2015-02-19 13:52 ` H.J. Lu
2015-02-20 8:01 ` Mark Wielaard
2015-02-18 17:00 ` Joel Sherrill
2015-02-19 2:42 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218165457.GU544@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).