From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [release/branch] Set GDB version number to str 7.9.
Date: Thu, 19 Feb 2015 12:23:00 -0000 [thread overview]
Message-ID: <20150219122319.GF23529@adacore.com> (raw)
In-Reply-To: <1424347460-31023-1-git-send-email-brobecker@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
> In preparation for the GDB 7.9 release, I am about to push
> this commit...
>
> gdb/ChangeLog:
>
> * version.in: Set GDB version number to str 7.9.
[...]
> diff --git a/gdb/version.in b/gdb/version.in
> index 8c98182..2d982e4 100644
> --- a/gdb/version.in
> +++ b/gdb/version.in
> @@ -1 +1 @@
> -7.8.90.DATE-cvs
> +str 7.9
For those who were actually paying attention (not me), there is
an obvious mistake in the version number.
For my penance, I'll explain how it happened:
I use a set of python scripts to do most of the grunt work.
The purpose is to make sure everything gets done without anything
falling through the cracks; and by doing most of it automatically,
I reduce the changes for errors. The scripts are configured via
a small yaml file. Normally, I'd just put write the version number
and done, but "7.9" looking like a float, I have to say "!!str 7.9"
instead. Except that I forgot the two leading "!!".
The scripts show me the diff before pushing, and asks me to confirm.
But I was sleeping at the wheel. Fortunately, I caught it slightly
later on. Attached is the patch that fixes the issue.
gdb/ChangeLog:
* version.in: Change to "7.9" instead of "str 7.9".
--
Joel
[-- Attachment #2: 0001-Fix-the-gdb-version-number-7.9-instead-of-str-7.9.patch --]
[-- Type: text/x-diff, Size: 1021 bytes --]
From 3b41352824ddc32dabca2d3281a03b4a0b8c7a27 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 19 Feb 2015 16:16:34 +0400
Subject: [PATCH] Fix the gdb version number ("7.9" instead of "str 7.9").
This fixes an obvious error in the previous change to this file.
gdb/ChangeLog:
* version.in: Change to "7.9" instead of "str 7.9".
---
gdb/ChangeLog | 4 ++++
gdb/version.in | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dd40512..4fc8c2d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2015-02-19 Joel Brobecker <brobecker@adacore.com>
+ * version.in: Set GDB version number to 7.9.
+
+2015-02-19 Joel Brobecker <brobecker@adacore.com>
+
* version.in: Set GDB version number to str 7.9.
2015-02-19 Joel Brobecker <brobecker@adacore.com>
diff --git a/gdb/version.in b/gdb/version.in
index 2d982e4..fbf1779 100644
--- a/gdb/version.in
+++ b/gdb/version.in
@@ -1 +1 @@
-str 7.9
+7.9
--
1.9.1
next prev parent reply other threads:[~2015-02-19 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 12:04 Joel Brobecker
2015-02-19 12:23 ` Joel Brobecker [this message]
2015-02-19 12:40 ` RFC: gdb-7.9-release tag on wrong commit (was: "Re: [release/branch] Set GDB version number to str 7.9.") Joel Brobecker
2015-02-19 12:45 ` Eli Zaretskii
2015-02-19 12:57 ` RFC: gdb-7.9-release tag on wrong commit Pedro Alves
2015-02-19 13:46 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219122319.GF23529@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).