From: Mike Frysinger <vapier@gentoo.org>
To: James Bowman <james.bowman@ftdichip.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, FT32] gdb and sim support
Date: Tue, 24 Feb 2015 04:52:00 -0000 [thread overview]
Message-ID: <20150224045154.GE13523@vapier> (raw)
In-Reply-To: <CA9BBF0458F83C4F9051448B941B57D1171BC0CB@glaexch1>
[-- Attachment #1: Type: text/plain, Size: 2745 bytes --]
On 23 Feb 2015 10:40, James Bowman wrote:
> > > 2014-02-03 James Bowman <james.bowman@ftdichip.com>
> > >
> > > * gdb/Makefile.in, gdb/configure.tgt: FT32 target added
> > > * sim/configure.tgt: FT32 target added
> > > * sim/configure: Regenerated
> > > * sim/ft32/configure: Regenerated
> > > * gdb/ft32-tdep.c,h: Support FT32
> > > * sim/ft32/*: FT32 simulator
> >
> > notes:
> > - ChangeLog entries are split up across dirs
>
> Do you mean I should not split? Organize in some other way?
see my patch here as an example:
https://sourceware.org/ml/gdb-patches/2014-03/msg00173.html
> > where's the testsuite man ? :) it should be trivial to start one with .s
> > files -- just look at sim/testsuite/sim/. otherwise there's no way to keep
> > regressions from slipping in.
>
> Good idea. We are currently running the gcc testsuite on the simulator
> as our regression test. Would it be OK if I defer, and add a sim
> testsuite after this submit?
that's what everyone says ;). the trouble with having no sim testsuite is that
people (like me) only use the sim testsuite to verify common/arch changes don't
break things. you don't need a comphrensive one, just one or two basic things.
that way we at least know the sim isn't completely hosed.
> > > +/* Use an invalid address value as 'not available' marker. */
> > > +enum { REG_UNAVAIL = (CORE_ADDR) -1 };
>
> This is actually the value -1 being cast. I have rewritten the line to
> make this clearer.
ah sorry about that
> > since you're a new port, you should start with SIM_AC_OPTION_WARNINGS enabled.
> > obviously that also means cleaning up all the warnings generated in the ft32/
> > subdir once you do :).
>
> Done - it now compiles without warnings. It would be nice to be able to
> build it with warnings as errors.
the functionality is in place, but it's disabled atm because the sim code has a
lot of legacy that needs cleaning. although might be good to bite that bullet
now and uncomment the lines in common/acinclude.m4 that disables it.
> > > --- /dev/null
> > > +++ b/sim/ft32/interp.c
> >
> > ideally you'd switch to sim-reg.o in your Makefile's SIM_OBJS ... that'll
> > provide these entry points. that would require also enabling sim-model.o
> > & SIM_AC_OPTION_DEFAULT_MODEL support, but i don't think that'd be too hard.
> > if you look at bfin/machs.c and start at "sim_machs", i think you should be
> > able to track it down easily enough.
>
> This change is causing me some trouble. OK to defer it until after the
> main submit?
mach/model support can wait
i'll follow up once i review the actual code ;)
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-24 4:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 4:06 James Bowman
2015-02-10 6:27 ` James Bowman
2015-02-17 10:21 ` Mike Frysinger
2015-02-19 7:06 ` Mike Frysinger
[not found] ` <ORIGINAL-RELEASE-1424557036-20150219070610.GI544@vapier>
2015-02-23 10:40 ` James Bowman
2015-02-24 4:52 ` Mike Frysinger [this message]
2015-03-10 16:56 ` James Bowman
2015-03-16 8:25 ` Mike Frysinger
2015-03-19 15:26 ` James Bowman
2015-03-19 18:52 ` Mike Frysinger
2015-03-20 2:57 ` James Bowman
2015-03-20 5:18 ` Mike Frysinger
2015-03-20 5:19 ` Mike Frysinger
2015-03-23 19:21 ` James Bowman
2015-03-26 7:10 ` Mike Frysinger
2015-03-26 19:05 ` James Bowman
2015-03-16 16:38 ` Mike Frysinger
2015-03-17 17:36 ` Joel Brobecker
2015-03-19 15:21 ` James Bowman
2015-03-19 18:54 ` Mike Frysinger
2015-03-20 3:01 ` James Bowman
2015-03-20 3:47 ` Mike Frysinger
2015-03-20 12:46 ` Joel Brobecker
2015-03-20 15:47 ` Mike Frysinger
2015-03-20 15:50 ` Joel Brobecker
2015-03-22 22:33 ` Mike Frysinger
2015-03-23 12:36 ` Joel Brobecker
2015-03-23 19:15 ` James Bowman
2015-03-23 23:04 ` Joel Brobecker
2015-03-28 6:21 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224045154.GE13523@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=james.bowman@ftdichip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).