From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46465 invoked by alias); 24 Feb 2015 05:44:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46452 invoked by uid 89); 24 Feb 2015 05:44:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD,URIBL_BLACK autolearn=no version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Feb 2015 05:44:44 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 5DC9D34092B; Tue, 24 Feb 2015 05:44:41 +0000 (UTC) Date: Tue, 24 Feb 2015 05:44:00 -0000 From: Mike Frysinger To: Andrew Bennett Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add micromips support to the MIPS simulator Message-ID: <20150224054441.GA6655@vapier> Mail-Followup-To: Andrew Bennett , gdb-patches@sourceware.org References: <0DA23CC379F5F945ACB41CF394B9827720F51185@LEMAIL01.le.imgtec.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <0DA23CC379F5F945ACB41CF394B9827720F51185@LEMAIL01.le.imgtec.org> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00687.txt.bz2 --opJtzjQTFsWo+cga Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1824 On 21 Jan 2015 12:44, Andrew Bennett wrote: the igen files i pretty much skimmed over > --- a/sim/mips/Makefile.in > +++ b/sim/mips/Makefile.in > > support.o: sim-main.h support.c $(SIM_EXTRA_DEPS) > idecode.o: sim-main.h idecode.c $(SIM_EXTRA_DEPS) > itable.o: sim-main.h itable.c $(SIM_EXTRA_DEPS) > -m16run.o: sim-main.h m16_idecode.h m32_idecode.h $(SIM_EXTRA_DEPS) > +m16run.o: sim-main.h m16_idecode.h m32_idecode.h m16run.c $(SIM_EXTRA_DE= PS) > +micromipsrun.o: sim-main.h micromips16_idecode.h micromips32_idecode.h \ > + micromips_m32_idecode.h micromipsrun.c $(SIM_EXTRA_DEPS) pretty sure you don't need any of this hand maintained dependency info anym= ore.=20=20 can you please try deleting it all instead ? > --- a/sim/mips/configure.ac > +++ b/sim/mips/configure.ac > > + *:*micromips32*:*) > + # Run igen thrice, once for micromips32, once for micromips16, > + # and once for m32. > + ws=3D"micromips_m32 micromips16 micromips32" indentation is broken slightly on the second comment line. seems to come u= p a=20 few times ... you should fix them all. > --- a/sim/mips/interp.c > +++ b/sim/mips/interp.c >=20=20 > +/* microMIPS ISA mode */ > +int isa_mode; why is this a global instead of being part of the sim state ? the comment also needs tweaking to match GNU style > --- /dev/null > +++ b/sim/mips/micromipsrun.c > > +/* Run function for the micromips simulator > + > + Copyright (C) 2005-2013 Free Software Foundation, Inc. years needs updating > + This file is part of GDB, the GNU debugger. i think you mean: This file is part of the GNU simulators. > +#define SD sd > +#define CPU cpu unused ? > +void > +sim_engine_run (SIM_DESC sd, int next_cpu_nr, int nr_cpus, int signal); you should include sim-engine.h instead of declaring the prototype yourself -mike --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU7A/JAAoJEEFjO5/oN/WBW4MP/Rja5lwv0maDPJ/rDxVQbwJ5 3T5tCiotd4fzG9IjSjwS4sT/NGuFTpS+ftDwsOku2/PiZmYo85QTpsIkf+CLTJH1 4NmjOkREaVXVkpIZDgrWjeWgUWr//ePE8qRI5QT1cmPmXVXM5+u0huYxHYugrF7T sG2eMnVIKzzJdrt0CvuuN+MAhMKHGmhL1FtySr9OrCdjq8T5r5vnt6m5N104yle+ sRk5Hrsh5TiFxYARz+MRdZlGeb38ABk855/kOrZ3+XwmJy/ohdyANw44wOab41xx VD8Dds5LUq1g78eocgTfBRtci1EpPAqM2ShJBRZ5ri993aOaz2cYDX1w/mnY8H5d 83CN2qxbmIC0yLVHxxyViZ2MtR7CZ4LLgDJdUZYRdulEvFi4IxPJWxx4iOnVI9Nh 7gQi+vP7hZ5kMnJMlBHeSZT1m3x62j6i3kOhWi+Wf/AXCJWBENCrzItf1ZBm43/1 8VXtjTVujw3LijNub/3tleK/mbQ3sp1FS1dSlA3BrXSkLC1jwyBd3swck5QhnS14 6Tt6KCu6Uc8vO3X8uX+XXMaCeENOjRxH6C5UT5ntznoLZCqYdwVHijEcbVPUE9lK LOHk1HVZcbAM1HIK2ZjYkn85oI8HCf/SRMLQK8zKX2UJTLmqurlcvJ4hEYgW6DxX A6lERR84iOHw2Oym2IKB =XYv9 -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--