From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116101 invoked by alias); 2 Mar 2015 15:02:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116081 invoked by uid 89); 2 Mar 2015 15:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 02 Mar 2015 15:01:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AE6191166FE; Mon, 2 Mar 2015 10:01:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id E5MqCXz6CCFi; Mon, 2 Mar 2015 10:01:56 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 619DF116602; Mon, 2 Mar 2015 10:01:56 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9928E40EAD; Mon, 2 Mar 2015 07:01:55 -0800 (PST) Date: Mon, 02 Mar 2015 15:02:00 -0000 From: Joel Brobecker To: John Baldwin Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: New ARI warning Fri Feb 27 01:54:21 UTC 2015 Message-ID: <20150302150155.GC4449@adacore.com> References: <20150227015421.GA60225@sourceware.org> <20150227082442.GF31815@adacore.com> <1663130.tPCgNL199S@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1663130.tPCgNL199S@ralph.baldwin.cx> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg00041.txt.bz2 > Yes, I've tried to follow that in my other patches (some of which I haven't > sent yet), but most of the code I work on follows the other style and old > habits die hard. :) :-) > Not sure if these sorts of fixes need a ChangeLog entry as well, but does > this address these? Yes, all changes require a ChangeLog entry (I have this wild and impossible dream that, one day, we will get rid of these ChangeLogs. One day...) > gdb/ChangeLog: > > * amd64fbsd-tdep.c (amd64fbsd_sigtramp_p): Style fixes. > * i386fbsd-tdep.c (i386fbsd_sigtramp_p): Likewise. > diff --git a/gdb/i386fbsd-tdep.c b/gdb/i386fbsd-tdep.c > index d4516ee..ed41706 100644 > --- a/gdb/i386fbsd-tdep.c > +++ b/gdb/i386fbsd-tdep.c > @@ -105,24 +105,24 @@ static const gdb_byte i386fbsd_osigtramp_end[] = > }; > > /* The three different trampolines are all the same size. */ > -gdb_static_assert (sizeof i386fbsd_sigtramp_start == > - sizeof i386fbsd_freebsd4_sigtramp_start); > -gdb_static_assert (sizeof i386fbsd_sigtramp_start == > - sizeof i386fbsd_osigtramp_start); > -gdb_static_assert (sizeof i386fbsd_sigtramp_middle == > - sizeof i386fbsd_freebsd4_sigtramp_middle); > -gdb_static_assert (sizeof i386fbsd_sigtramp_middle == > - sizeof i386fbsd_osigtramp_middle); > -gdb_static_assert (sizeof i386fbsd_sigtramp_end == > - sizeof i386fbsd_freebsd4_sigtramp_end); > -gdb_static_assert (sizeof i386fbsd_sigtramp_end == > - sizeof i386fbsd_osigtramp_end); > +gdb_static_assert (sizeof i386fbsd_sigtramp_start > + == sizeof i386fbsd_freebsd4_sigtramp_start); > +gdb_static_assert (sizeof i386fbsd_sigtramp_start > + == sizeof i386fbsd_osigtramp_start); > +gdb_static_assert (sizeof i386fbsd_sigtramp_middle > + == sizeof i386fbsd_freebsd4_sigtramp_middle); > +gdb_static_assert (sizeof i386fbsd_sigtramp_middle > + == sizeof i386fbsd_osigtramp_middle); > +gdb_static_assert (sizeof i386fbsd_sigtramp_end > + == sizeof i386fbsd_freebsd4_sigtramp_end); > +gdb_static_assert (sizeof i386fbsd_sigtramp_end > + == sizeof i386fbsd_osigtramp_end); > > /* We assume that the middle is the largest chunk below. */ > -gdb_static_assert (sizeof i386fbsd_sigtramp_middle > > - sizeof i386fbsd_sigtramp_start); > -gdb_static_assert (sizeof i386fbsd_sigtramp_middle > > - sizeof i386fbsd_sigtramp_end); > +gdb_static_assert (sizeof i386fbsd_sigtramp_middle > + > sizeof i386fbsd_sigtramp_start); > +gdb_static_assert (sizeof i386fbsd_sigtramp_middle > + > sizeof i386fbsd_sigtramp_end); You'll need to mention those in the ChangeLog as well. Since there is no function as the context, I would probably say something like this: * i386fbsd-tdep.c: Fix style in various gdb_static_assert expressions. ? Otherwise, looks good to me. Thanks! -- Joel