From: Gary Benson <gbenson@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] New common function "startswith"
Date: Tue, 03 Mar 2015 17:16:00 -0000 [thread overview]
Message-ID: <20150303171612.GA7569@blade.nx> (raw)
In-Reply-To: <20150303160639.GB3243@adacore.com>
Joel Brobecker wrote:
> > This patch introduces a new common function "startswith" which
> > takes two string arguments and returns nonzero if the first string
> > starts with the second. It also updates the 180 places where this
> > logic was written out longhand to use the new function.
> >
> > I almost pushed this as obvious, but I hesitated because of its
> > size.
> >
> > --
> > gdb/ChangeLog:
> >
> > * common/common-utils.h (startswith): New declaration.
> > * common/common-utils.c (startswith): New Function.
> > All places where this logic was used updated to use the above.
>
> Given the obvious errors in remote.c that you just fixed, I'd say
> this is going to be a very useful function.
Yeah, that's what prompted it :)
> > diff --git a/gdb/common/common-utils.c b/gdb/common/common-utils.c
> > index 2925dd5..5fb4af1 100644
> > --- a/gdb/common/common-utils.c
> > +++ b/gdb/common/common-utils.c
> > @@ -151,3 +151,11 @@ savestring (const char *ptr, size_t len)
> > p[len] = 0;
> > return p;
> > }
> > +
> > +/* See common-utils.h. */
> > +
> > +int
> > +startswith (const char *s1, const char *s2)
> > +{
> > + return startswith (s1, s2);
> > +}
>
> As pointed out by Andreas... ;-)
So the automated find and replace thing I wrote found and replaced
that one...
> Also, how about we rename the parameters to something like "str"
> instead of "s1" and "pattern" for s2. It makes it faster, IMO, to
> figure out the parameter order without having to read the function's
> documentation, and therefore makes it's use a little less
> error-prone.
I can do that. I also found some more, with the pattern
strncmp (string, "something", sizeof ("something") -1)
so I'll update the patch to include those too.
> I only skimmed through the patch, but it otherwise looks good to me.
Cool, thanks for reviewing.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-03-03 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 13:10 Gary Benson
2015-03-03 15:49 ` Andreas Arnez
2015-03-03 16:06 ` Joel Brobecker
2015-03-03 17:16 ` Gary Benson [this message]
2015-03-03 18:34 ` Andreas Arnez
2015-03-04 9:27 ` Gary Benson
2015-03-04 16:27 ` [PATCH v2] " Gary Benson
2015-03-05 18:18 ` Joel Brobecker
2015-03-06 9:48 ` Gary Benson
2015-03-04 8:45 ` [PATCH] " Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303171612.GA7569@blade.nx \
--to=gbenson@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).