From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111972 invoked by alias); 17 Mar 2015 22:59:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111962 invoked by uid 89); 17 Mar 2015 22:59:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Mar 2015 22:59:42 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 6D72734094A; Tue, 17 Mar 2015 22:59:40 +0000 (UTC) Date: Tue, 17 Mar 2015 22:59:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 02/13] sim/erc32: Removed type mismatch compiler warnings Message-ID: <20150317225940.GK8109@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1426626170-21401-1-git-send-email-jiri@gaisler.se> <1426626170-21401-3-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/0P/MvzTfyTu5j9Q" Content-Disposition: inline In-Reply-To: <1426626170-21401-3-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00530.txt.bz2 --/0P/MvzTfyTu5j9Q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 544 On 17 Mar 2015 22:02, Jiri Gaisler wrote: > * func.c (exec_cmd) : silence compiler warnings when calling system(). > (batch) : replace fgets() with getline(). rewrote this for you > --- a/sim/erc32/func.c > +++ b/sim/erc32/func.c > @@ -80,20 +80,24 @@ batch(sregs, fname) > char *fname; > { > FILE *fp; > - char lbuf[1024]; > + char *lbuf = NULL; > + size_t len = 0; > + ssize_t tmp; i deleted this tmp for you as it's unused otherwise, pushed, thanks! -mike --/0P/MvzTfyTu5j9Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVCLHcAAoJEEFjO5/oN/WB+M0QAJ+SkACBrIl12qS/HgXJf6LU K1nHkeXX5whuRH8BM0I5zS8yTQLxMck1bFEthfxs9qZpQsNkUJMxEdyFWRVJ45g3 ERq6uU0Bj//tYGlkXRKiUWBr39kU4eh9y+87akQ05er/2eTNGwzLj6NS3WKV2o17 MK51lUZEVrlnsqf3ZL37/qT/FQJVilzpz8VgedNpx1cEWn8tKWYTAEmlwHzpY1BF Iz4Dve6+EcnLx+ea+4yfUarsdE03z99GgUWkpeogv07GQOX7cC0i4LdZ5xi5/wxW krDTzdCpzIsHIpLvu9qTeRpvVxay2rWZf2vASw7dULaoGouCBasuxMkWXfjD/rLV DC+DYnwzPtf3Xdz6N7yAZUuWt0HnFmYSjpBbUOTCH+5OA4vMeMhfk/Y20wUnt9/e 9E6Yz9NQlpDVPIzxsY3/z/t5WwRl4jKHXTMhTjEGs7HbuieI+I+eqV1oxkmE3SY+ oEtbiODITheXhe46VGs9QVpo+aOZiunX/fIo1sjbGSWuVYnNF0urGDGF8At69l07 9BYHMlMoIb7Ajrto9rM5cIxXHPWWNj8+YkblyFR3PnYlWGcHhgMJOdxqGb/Lg6ev 77/17ExQwInWFyOTmUp7HgihclRnKXiIYlnN81jsZSnFHSc+90QQVhGnPswJXuQk JWSOGQQoDR80yU05q68J =cGpO -----END PGP SIGNATURE----- --/0P/MvzTfyTu5j9Q--