public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: James Bowman <james.bowman@ftdichip.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, FT32] gdb and sim support
Date: Thu, 19 Mar 2015 18:54:00 -0000	[thread overview]
Message-ID: <20150319185452.GA14215@vapier> (raw)
In-Reply-To: <CA9BBF0458F83C4F9051448B941B57D117232A0A@glaexch1>

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On 19 Mar 2015 15:21, James Bowman wrote:
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1339,9 +1340,9 @@ init.c: $(INIT_FILES)
>  	done | \
>  	while read f; do \
>  	    case " $$fs " in \
> -	        *" $$f "* ) ;; \
> -	        * ) echo $$f ; fs="$$fs $$f";; \
> -            esac; \
> +		*" $$f "* ) ;; \
> +		* ) echo $$f ; fs="$$fs $$f";; \
> +	    esac; \
>  	done >> init.l-tmp
>  	@echo '/* Do not modify this file.  */' >>init.c-tmp
>  	@echo '/* It is created automatically by the Makefile.  */'>>init.c-tmp

you should delete unrelated whitespace changes from your submission

> @@ -1870,13 +1872,13 @@ po/$(PACKAGE).pot: force
>  	    $(FLEX) -o$@ $< && \
>  	    rm -f $@.new && \
>  	    sed -e '/extern.*malloc/d' \
> -	        -e '/extern.*realloc/d' \
> -	        -e '/extern.*free/d' \
> -	        -e '/include.*malloc.h/d' \
> -	        -e 's/\([^x]\)malloc/\1xmalloc/g' \
> -	        -e 's/\([^x]\)realloc/\1xrealloc/g' \
> -	        -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
> -	        -e 's/\([ \t;,(]\)free$$/\1xfree/g' \
> +		-e '/extern.*realloc/d' \
> +		-e '/extern.*free/d' \
> +		-e '/include.*malloc.h/d' \
> +		-e 's/\([^x]\)malloc/\1xmalloc/g' \
> +		-e 's/\([^x]\)realloc/\1xrealloc/g' \
> +		-e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
> +		-e 's/\([ \t;,(]\)free$$/\1xfree/g' \
>  		-e 's/yy_flex_xrealloc/yyxrealloc/g' \
>  	      < $@ > $@.new && \
>  	    rm -f $@ && \

this too

> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt

you've included a lot of unrelated changes in this too
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-03-19 18:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  4:06 James Bowman
2015-02-10  6:27 ` James Bowman
2015-02-17 10:21   ` Mike Frysinger
2015-02-19  7:06 ` Mike Frysinger
     [not found] ` <ORIGINAL-RELEASE-1424557036-20150219070610.GI544@vapier>
2015-02-23 10:40   ` James Bowman
2015-02-24  4:52     ` Mike Frysinger
2015-03-10 16:56       ` James Bowman
2015-03-16  8:25         ` Mike Frysinger
2015-03-19 15:26           ` James Bowman
2015-03-19 18:52             ` Mike Frysinger
2015-03-20  2:57               ` James Bowman
2015-03-20  5:18                 ` Mike Frysinger
2015-03-20  5:19                   ` Mike Frysinger
2015-03-23 19:21                     ` James Bowman
2015-03-26  7:10                       ` Mike Frysinger
2015-03-26 19:05                         ` James Bowman
2015-03-16 16:38         ` Mike Frysinger
2015-03-17 17:36         ` Joel Brobecker
2015-03-19 15:21           ` James Bowman
2015-03-19 18:54             ` Mike Frysinger [this message]
2015-03-20  3:01               ` James Bowman
2015-03-20  3:47                 ` Mike Frysinger
2015-03-20 12:46                 ` Joel Brobecker
2015-03-20 15:47                   ` Mike Frysinger
2015-03-20 15:50                     ` Joel Brobecker
2015-03-22 22:33                       ` Mike Frysinger
2015-03-23 12:36                         ` Joel Brobecker
2015-03-23 19:15                           ` James Bowman
2015-03-23 23:04                             ` Joel Brobecker
2015-03-28  6:21 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319185452.GA14215@vapier \
    --to=vapier@gentoo.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=james.bowman@ftdichip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).