From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106179 invoked by alias); 26 Mar 2015 17:50:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106170 invoked by uid 89); 26 Mar 2015 17:50:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Mar 2015 17:50:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A190028368; Thu, 26 Mar 2015 13:50:29 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AoxRX1wN58qN; Thu, 26 Mar 2015 13:50:29 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 720D828348; Thu, 26 Mar 2015 13:50:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D411240EAD; Thu, 26 Mar 2015 10:50:28 -0700 (PDT) Date: Thu, 26 Mar 2015 17:50:00 -0000 From: Joel Brobecker To: "Jose E. Marchesi" Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [PATCH V4 5/9] New probe type: DTrace USDT probes. Message-ID: <20150326175028.GA13867@adacore.com> References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> <1422874968-382-6-git-send-email-jose.marchesi@oracle.com> <87r3tp722i.fsf@redhat.com> <20150325191418.GA32233@adacore.com> <87bnjfraq1.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bnjfraq1.fsf@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg00863.txt.bz2 > Well, the TRY..CATCH in your prototype would catch any error that may be > thrown in parse_expression, and the `set_language' must take care of > changing the language, so I would say that is enough... OK - I will send an updated patch that makes things a little cleaner. I didn't know whether it was OK to default to type long makes much sense when the probe says the parameter should be using type "mutex_t". > And once I had that fixed, the next issue that I looked at was: > > (gdb) b adainit > Breakpoint 1 at 0x8051f03 > (gdb) run > Starting program: /[...]/a > [Thread debugging using libthread_db enabled] > zsh: 12378 segmentation fault (core dumped) /[...]/gdb -q a > > This is where I'm getting even more out of my league, here. > The SEGV happens on the following line: > > 377 uint32_t enabler_offset > 378 = ((uint32_t *) eofftab)[DOF_UINT (dof, probe->dofpr_enoffidx) + i]; > > I will debug that SIGSEGV in solaris, but the problem seems to be > related to the DOF program embedded in your program, more than to the > platform. > > Could you please send me your sparc-solaris reproducer? Thanks for the offer to help! Sadly, the SEGV doesn't seem to happen on sparc-solaris, it seems. Once I apply the patch above, I pretty much get normal results back (yay!). So, the problem appears to be specific to x86-solaris. I didn't know the DOF program was embedded in the executable, but I suspect there is a problem in its contents. How do you think we should proceed? Thanks! -- Joel