public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Phil Muldoon <pmuldoon@redhat.com>
Subject: [PATCH 2/4] compile: Add new field scope_data
Date: Thu, 26 Mar 2015 20:57:00 -0000	[thread overview]
Message-ID: <20150326205737.28223.24573.stgit@host1.jankratochvil.net> (raw)
In-Reply-To: <20150326205727.28223.54648.stgit@host1.jankratochvil.net>

Provide a way to associate more data with enum compile_i_scope_types up to the
struct do_module_cleanup stage.

It should be all sub-classed but AFAIK GDB does not require C++ compiler yet.

gdb/ChangeLog
2015-03-26  Jan Kratochvil  <jan.kratochvil@redhat.com>

        * cli/cli-script.c (execute_control_command): Update
	eval_compile_command caller.
	* compile/compile-object-load.h (struct compile_module): Add field
	scope_data.
	* compile/compile-object-run.c (struct do_module_cleanup): Add field
	scope_data.
        (compile_object_run): Propage the field scope_data.
	* compile/compile.c (compile_file_command, compile_code_command):
	Update eval_compile_command callers.
        (eval_compile_command): Add parameter scope_data.  Set it.
        * compile/compile.h (eval_compile_command): Add parameter scope_data.
        * defs.h (struct command_line): Add field scope_data.
---
 gdb/cli/cli-script.c              |    3 ++-
 gdb/compile/compile-object-load.h |    3 +++
 gdb/compile/compile-object-run.c  |    4 ++++
 gdb/compile/compile.c             |    7 ++++---
 gdb/compile/compile.h             |    3 ++-
 gdb/defs.h                        |    1 +
 6 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index 7a4ed78..4bd18a7 100644
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -615,7 +615,8 @@ execute_control_command (struct command_line *cmd)
       }
 
     case compile_control:
-      eval_compile_command (cmd, NULL, cmd->control_u.compile.scope);
+      eval_compile_command (cmd, NULL, cmd->control_u.compile.scope,
+			    cmd->control_u.compile.scope_data);
       ret = simple_control;
       break;
 
diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h
index bef575e..ed3ac3a 100644
--- a/gdb/compile/compile-object-load.h
+++ b/gdb/compile/compile-object-load.h
@@ -31,6 +31,9 @@ struct compile_module
   /* Inferior registers address or NULL if the inferior function does not
      require any.  */
   CORE_ADDR regs_addr;
+
+  /* User data for enum compile_i_scope_types in use.  */
+  void *scope_data;
 };
 
 extern struct compile_module *compile_object_load (const char *object_file,
diff --git a/gdb/compile/compile-object-run.c b/gdb/compile/compile-object-run.c
index 6738aad..0864712 100644
--- a/gdb/compile/compile-object-run.c
+++ b/gdb/compile/compile-object-run.c
@@ -36,6 +36,9 @@ struct do_module_cleanup
   /* .c file OBJFILE was built from.  It needs to be xfree-d.  */
   char *source_file;
 
+  /* User data for enum compile_i_scope_types in use.  */
+  void *scope_data;
+
   /* objfile_name of our objfile.  */
   char objfile_name_string[1];
 };
@@ -96,6 +99,7 @@ compile_object_run (struct compile_module *module)
   data->executedp = &executed;
   data->source_file = xstrdup (module->source_file);
   strcpy (data->objfile_name_string, objfile_name_s);
+  data->scope_data = module->scope_data;
 
   xfree (module->source_file);
   xfree (module);
diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c
index 1d342a0..7fe556d 100644
--- a/gdb/compile/compile.c
+++ b/gdb/compile/compile.c
@@ -117,7 +117,7 @@ compile_file_command (char *arg, int from_tty)
   make_cleanup (xfree, arg);
   buffer = xstrprintf ("#include \"%s\"\n", arg);
   make_cleanup (xfree, buffer);
-  eval_compile_command (NULL, buffer, scope);
+  eval_compile_command (NULL, buffer, scope, NULL);
   do_cleanups (cleanup);
 }
 
@@ -150,7 +150,7 @@ compile_code_command (char *arg, int from_tty)
     }
 
   if (arg && *arg)
-      eval_compile_command (NULL, arg, scope);
+    eval_compile_command (NULL, arg, scope, NULL);
   else
     {
       struct command_line *l = get_command_line (compile_control, "");
@@ -555,7 +555,7 @@ compile_command (char *args, int from_tty)
 
 void
 eval_compile_command (struct command_line *cmd, char *cmd_string,
-		      enum compile_i_scope_types scope)
+		      enum compile_i_scope_types scope, void *scope_data)
 {
   char *object_file, *source_file;
 
@@ -572,6 +572,7 @@ eval_compile_command (struct command_line *cmd, char *cmd_string,
       compile_module = compile_object_load (object_file, source_file);
       discard_cleanups (cleanup_unlink);
       do_cleanups (cleanup_xfree);
+      compile_module->scope_data = scope_data;
       compile_object_run (compile_module);
     }
 }
diff --git a/gdb/compile/compile.h b/gdb/compile/compile.h
index 1e3f934..93c4786 100644
--- a/gdb/compile/compile.h
+++ b/gdb/compile/compile.h
@@ -29,7 +29,8 @@ struct dynamic_prop;
    never both.  */
 
 extern void eval_compile_command (struct command_line *cmd, char *cmd_string,
-				  enum compile_i_scope_types scope);
+				  enum compile_i_scope_types scope,
+				  void *scope_data);
 
 /* Compile a DWARF location expression to C, suitable for use by the
    compiler.
diff --git a/gdb/defs.h b/gdb/defs.h
index 72512f6..6476f80 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -400,6 +400,7 @@ struct command_line
 	struct
 	  {
 	    enum compile_i_scope_types scope;
+	    void *scope_data;
 	  }
 	compile;
       }

  reply	other threads:[~2015-03-26 20:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 20:57 [PATCH 1/4] Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-03-26 20:57 ` Jan Kratochvil [this message]
2015-04-06 17:28   ` obsolete: [PATCH 2/4] compile: Add new field scope_data Jan Kratochvil
2015-03-26 20:57 ` [PATCH 3/4] compile: Constify some parameters Jan Kratochvil
2015-04-06 17:28   ` obsolete: " Jan Kratochvil
2015-03-26 20:58 ` [PATCH 4/4] compile: New 'compile print' Jan Kratochvil
2015-03-26 20:59   ` Jan Kratochvil
2015-03-27  7:18   ` Eli Zaretskii
2015-03-27  7:33     ` Jan Kratochvil
2015-03-27  7:41       ` Eli Zaretskii
2015-03-27  7:56         ` Phil Muldoon
2015-03-27  9:08           ` Eli Zaretskii
2015-03-27  9:10           ` Eli Zaretskii
2015-03-27  9:16             ` Jan Kratochvil
2015-03-27  9:56               ` Eli Zaretskii
2015-03-27 10:11                 ` Jan Kratochvil
2015-03-27 10:20                 ` Phil Muldoon
2015-03-27 13:09                   ` Eli Zaretskii
2015-03-27 10:24                 ` Jan Kratochvil
2015-03-27 13:12                   ` Eli Zaretskii
2015-04-05 17:01   ` cancel: " Jan Kratochvil
2015-04-06 17:29   ` obsolete: " Jan Kratochvil
2015-03-27 20:06 ` [PATCH 1/4] v2: Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-04-06 17:27   ` obsolete: " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326205737.28223.24573.stgit@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).