From: Mike Frysinger <vapier@gentoo.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd
Date: Tue, 31 Mar 2015 06:13:00 -0000 [thread overview]
Message-ID: <20150331061337.GA30996@vapier> (raw)
In-Reply-To: <20150326155711.GA10088@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On 26 Mar 2015 08:57, H.J. Lu wrote:
> --- a/bfd/configure.ac
> +++ b/bfd/configure.ac
>
> -# Link in zlib if we can. This allows us to read compressed debug sections.
> -# This is used only by compress.c.
> -AM_ZLIB
> +# Use the system's zlib library.
> +zlibdir=-L../zlib
> +zlibinc="-I\$(srcdir)/../zlib"
> +AC_ARG_WITH(system-zlib,
> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])],
> +zlibdir=
> +zlibinc=
> +)
this is wrong. the 3rd arg is whether the option was specified, not that the
option was disabled. you need to check $withval is equal to "no" (or not equal
to "yes").
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-31 6:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 15:57 H.J. Lu
2015-03-29 14:10 ` H.J. Lu
2015-03-30 15:52 ` Steve Ellcey
2015-03-30 16:32 ` H.J. Lu
2015-03-30 16:45 ` Luis Machado
2015-03-30 16:51 ` H.J. Lu
2015-03-30 17:13 ` Steve Ellcey
2015-03-30 17:21 ` H.J. Lu
2015-03-30 17:36 ` Steve Ellcey
2015-03-30 19:33 ` Antoine Tremblay
2015-03-30 19:37 ` Antoine Tremblay
2015-03-31 17:13 ` Antoine Tremblay
2015-03-31 17:16 ` H.J. Lu
2015-03-31 17:18 ` Antoine Tremblay
2015-03-31 18:55 ` H.J. Lu
2015-03-31 20:16 ` H.J. Lu
2015-04-01 12:18 ` Antoine Tremblay
2015-04-02 3:22 ` Bin.Cheng
2015-04-02 3:53 ` Bin.Cheng
2015-03-30 20:19 ` H.J. Lu
2015-03-31 12:08 ` Antoine Tremblay
2015-03-30 18:18 ` Luis Machado
2015-03-30 17:20 ` H.J. Lu
2015-03-31 6:13 ` Mike Frysinger [this message]
2015-03-31 10:10 ` H.J. Lu
2015-03-31 10:37 ` Pedro Alves
2015-03-31 10:46 ` H.J. Lu
2015-03-31 10:53 ` Pedro Alves
2015-03-31 11:33 ` H.J. Lu
2015-03-31 11:46 ` Pedro Alves
2015-03-31 12:01 ` H.J. Lu
2015-03-31 12:15 ` Pedro Alves
2015-03-31 13:43 ` H.J. Lu
2015-03-31 13:46 ` Pedro Alves
2015-03-31 16:41 ` Mike Frysinger
2015-03-31 16:56 ` H.J. Lu
2015-03-31 17:01 ` Mike Frysinger
2015-03-31 17:04 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331061337.GA30996@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).