From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123095 invoked by alias); 31 Mar 2015 16:41:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123074 invoked by uid 89); 31 Mar 2015 16:41:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 16:41:08 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 04EAD34084F; Tue, 31 Mar 2015 16:41:05 +0000 (UTC) Date: Tue, 31 Mar 2015 16:41:00 -0000 From: Mike Frysinger To: "H.J. Lu" Cc: Binutils , GDB Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd Message-ID: <20150331164107.GI25224@vapier> Mail-Followup-To: "H.J. Lu" , Binutils , GDB References: <20150326155711.GA10088@gmail.com> <20150331061337.GA30996@vapier> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y+Z5jE7Arku/2GrR" Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01057.txt.bz2 --Y+Z5jE7Arku/2GrR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1186 On 31 Mar 2015 03:10, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 11:13 PM, Mike Frysinger wrote: > > On 26 Mar 2015 08:57, H.J. Lu wrote: > >> --- a/bfd/configure.ac > >> +++ b/bfd/configure.ac > >> > >> -# Link in zlib if we can. This allows us to read compressed debug se= ctions. > >> -# This is used only by compress.c. > >> -AM_ZLIB > >> +# Use the system's zlib library. > >> +zlibdir=3D-L../zlib > >> +zlibinc=3D"-I\$(srcdir)/../zlib" > >> +AC_ARG_WITH(system-zlib, > >> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])], > >> +zlibdir=3D > >> +zlibinc=3D > >> +) > > > > this is wrong. the 3rd arg is whether the option was specified, not th= at the > > option was disabled. you need to check $withval is equal to "no" (or n= ot equal > > to "yes"). >=20 > That is what gcc/configure.ac has and it works for me. then gcc/configure.ac is also broken. whether "it works for me" is irrelevant -- simply read the code and you'll see it's wrong. if you pass --without-system-zlib the code wrongly behaves as if you passed --with-system-zlib. i mention this because it is breaking my test builds. not that that really matters -- the code is clearly incorrect. -mike --Y+Z5jE7Arku/2GrR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVGs4jAAoJEEFjO5/oN/WBn2YQANcyEX6dxn84Tno8sR1V/r00 ICaF9A5xvVMY7hDgsqFaQANmI+/Zvy5duW13i2VSAkNqpTUY+z+S4qc6ZxOfs1/r geFEMNsIvrY7anBNrtnQRg09nntmnT3CCUwTCj5JS5rmCnFipu9GJ52Vg7M3zcCQ 6IHKBRDGBEuWd1vL9bTKlqDxDeHp5bpyHCTt5/JaqiLtNkKPHtyPHcwqwBxoD1/c poCPFDEiR2MNzWAzeKeSPLj2z9JlYJhd+DtIVNnTtjAfgNg0pv4bReSliQ4b3IYF WjV5qeMv1Rc97E72/11mr7MFJl6EE73CAPHVNC89l8Myb+ig4IMtUruHgsd/4fJK gzs4eIK7a5Q/B2JeplZ39yE/lsxfR3DeOy5ryft0JTOLjQldDMvKHwegYxWGVcBv DIEeE4ODckAngjvhEdOED6HXXxGAaiqB8FzMi1yIdP12L1TvHSv/ZzR+ZRO0r+AS DjVvNm3bdQ+HdVKMp1it4EEOBluj/cdVIYT17xKhxMLiHG/wJ0/ccgIUBBKrn5qg rEgmm/q2eRuQEew31V3fLfakSgJ9dy5gOpUYKuvDg1e9KlMi6q+uGYsJ2Nfcnutq eM+uzd5U1+AFMaac/lzAhWcypuIxTM/FvaJ5KuUONGMIf0qEmpjllZ3Hgkgaf+Az 5B9MhUWAAA51I7abp8AW =gRdT -----END PGP SIGNATURE----- --Y+Z5jE7Arku/2GrR--