From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43635 invoked by alias); 1 Apr 2015 13:48:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43616 invoked by uid 89); 1 Apr 2015 13:48:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 13:48:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t31DmECh017826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 1 Apr 2015 09:48:15 -0400 Received: from blade.nx (ovpn-116-118.ams2.redhat.com [10.36.116.118]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31DmEca006114; Wed, 1 Apr 2015 09:48:14 -0400 Received: by blade.nx (Postfix, from userid 1000) id 7938B26410B; Wed, 1 Apr 2015 14:48:13 +0100 (BST) Date: Wed, 01 Apr 2015 13:48:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Convert "remote:" sysroots to "target:" and remove "remote:" Message-ID: <20150401134813.GD655@blade.nx> References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <1426870087-32654-5-git-send-email-gbenson@redhat.com> <551BE101.6040103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551BE101.6040103@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00044.txt.bz2 Pedro Alves wrote: > Looks good. > > On 03/20/2015 04:48 PM, Gary Benson wrote: > > +/* Wrapper for reload_shared_libraries that replaces "remote:" > > + at the start of gdb_sysroot with "target:". */ > > + > > +static void > > +gdb_sysroot_changed (char *ignored, int from_tty, > > + struct cmd_list_element *e) > > +{ > > + const char *old_prefix = "remote:"; > > + const char *new_prefix = TARGET_SYSROOT_PREFIX; > > + > > + if (startswith (gdb_sysroot, old_prefix)) > > + { > > + gdb_assert (strlen (old_prefix) == strlen (new_prefix)); > > + memcpy (gdb_sysroot, new_prefix, strlen (new_prefix)); > > Should this output a warning (once per gdb invocation)? Sure, I'll add one. Cheers, Gary -- http://gbenson.net/