From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102152 invoked by alias); 3 Apr 2015 17:38:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102138 invoked by uid 89); 3 Apr 2015 17:38:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 03 Apr 2015 17:37:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 929DBD36BC; Fri, 3 Apr 2015 13:37:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TxpRrOSxn-gU; Fri, 3 Apr 2015 13:37:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 64843D332D; Fri, 3 Apr 2015 13:37:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 846B840EAD; Fri, 3 Apr 2015 10:37:57 -0700 (PDT) Date: Fri, 03 Apr 2015 17:38:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: GDB Patches Subject: Re: [PATCH 1/2] Preserve typedef layer when getting struct element Message-ID: <20150403173757.GF4704@adacore.com> References: <551E8B6D.4070706@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551E8B6D.4070706@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-04/txt/msg00123.txt.bz2 > gdb/ChangeLog: > > * ada-lang.c (ada_is_tagged_type): Add call to ada_check_typedef. > (ada_lookup_struct_elt_type): Remove calls to ada_check_typedef. > (template_to_static_fixed_type): Call ada_check_typedef only > when necessary. > > gdb/testsuite/ChangeLog: > > * gdb.ada/rec_comp: New testcase. > > No regression on x86_64-linux. Ok to push? Thanks, Pierre-Marie. This one looks good and can be checked in on its own. -- Joel