From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122371 invoked by alias); 7 Apr 2015 12:45:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122323 invoked by uid 89); 7 Apr 2015 12:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 07 Apr 2015 12:45:56 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Apr 2015 13:45:53 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 7 Apr 2015 13:45:52 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 72B6D2190046 for ; Tue, 7 Apr 2015 13:45:38 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t37CjpEY22675536 for ; Tue, 7 Apr 2015 12:45:51 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t37Cjjwb008020 for ; Tue, 7 Apr 2015 06:45:51 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t37CjfGk007933; Tue, 7 Apr 2015 06:45:42 -0600 Message-Id: <201504071245.t37CjfGk007933@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 07 Apr 2015 14:45:41 +0200 Subject: Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init To: palves@redhat.com (Pedro Alves) Date: Tue, 07 Apr 2015 12:45:00 -0000 From: "Ulrich Weigand" Cc: peterschauer@gmx.net (Peter Schauer), qiyaoltc@gmail.com (Yao Qi), gdb-patches@sourceware.org In-Reply-To: <551D04AC.7000206@redhat.com> from "Pedro Alves" at Apr 02, 2015 09:58:20 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040712-0009-0000-0000-000003BC340A X-SW-Source: 2015-04/txt/msg00197.txt.bz2 Pedro Alves wrote: > Ulrich, any idea why cannot_step_breakpoint was ever needed > for the SPU? It's been set since spu-tdep.c was committed upstream, and in fact it's set in every single version in our internal repositories of the code before it went upstream, too. (Going back over 10 years.) But I don't know why it was added either, since SPU has been using software single-step forever too, and even the very first version of GDB we patched to support SPU would ignore cannot_step_breakpoint for software single-step architectures ... So I'd say just go ahead and remove it. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com