From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31444 invoked by alias); 8 Apr 2015 16:56:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31435 invoked by uid 89); 8 Apr 2015 16:56:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Apr 2015 16:56:17 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Apr 2015 17:56:14 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 8 Apr 2015 17:56:11 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8FB242190046 for ; Wed, 8 Apr 2015 17:55:57 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t38GuBuh49479840 for ; Wed, 8 Apr 2015 16:56:11 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t38GuApE008928 for ; Wed, 8 Apr 2015 10:56:10 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-199.boeblingen.de.ibm.com [9.152.213.199]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t38GuAOB008925; Wed, 8 Apr 2015 10:56:10 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 38A09CF20; Wed, 8 Apr 2015 18:56:10 +0200 (CEST) Subject: Re: [PATCH 1/7 v3] powerpc: Support z-point type in gdbserver. To: cole945@gmail.com (Wei-cheng Wang) Date: Wed, 08 Apr 2015 16:56:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1427733032-64989-1-git-send-email-cole945@gmail.com> from "Wei-cheng Wang" at Mar 31, 2015 12:30:26 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150408165610.38A09CF20@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040816-0013-0000-0000-0000039437D4 X-SW-Source: 2015-04/txt/msg00280.txt.bz2 Wei-cheng Wang wrote: > +/* Implement supports_z_point_type target-ops. > + Returns true if type Z_TYPE breakpoint is supported. > + > + Handling software breakpoint at server side, so tracepoints > + and breakpoints can be inserted at the same location. */ > + > +static int > +ppc_supports_z_point_type (char z_type) > +{ > + switch (z_type) > + { > + case Z_PACKET_SW_BP: > + return 1; > + case Z_PACKET_HW_BP: > + case Z_PACKET_WRITE_WP: > + case Z_PACKET_ACCESS_WP: > + default: > + return 0; > + } > +} Well, if we add a function that returns true on supports_z_point_type for Z_PACKET_SW_BP, then we also need to provide functions that actually do insert/remove such breakpoints. (I know that you have that in the next patch, but each patch in a series should be functionally correct on its own, so they really should be here.) Otherwise looks good. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com