From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60598 invoked by alias); 8 Apr 2015 17:02:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60580 invoked by uid 89); 8 Apr 2015 17:02:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Apr 2015 17:01:59 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Apr 2015 18:01:56 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 8 Apr 2015 18:01:55 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1DFDC2190046 for ; Wed, 8 Apr 2015 18:01:41 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t38H1sMu66650184 for ; Wed, 8 Apr 2015 17:01:54 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t38H1sY4015384 for ; Wed, 8 Apr 2015 11:01:54 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-199.boeblingen.de.ibm.com [9.152.213.199]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t38H1rug015355; Wed, 8 Apr 2015 11:01:54 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id D167BCF20; Wed, 8 Apr 2015 19:01:53 +0200 (CEST) Subject: Re: [PATCH 3/7 v3] Add testcases for ppc64 tracepoint. To: cole945@gmail.com (Wei-cheng Wang) Date: Wed, 08 Apr 2015 17:02:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, cole945@gmail.com (Wei-cheng Wang) In-Reply-To: <1427733032-64989-3-git-send-email-cole945@gmail.com> from "Wei-cheng Wang" at Mar 31, 2015 12:30:28 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150408170153.D167BCF20@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040817-0025-0000-0000-000004A343CF X-SW-Source: 2015-04/txt/msg00282.txt.bz2 Wei-cheng Wang wrote: > 2015-03-30 Wei-cheng Wang > > * gdb.trace/backtrace.exp: Set registers for powerpc*-*-*. > * gdb.trace/collection.exp: Ditto. > * gdb.trace/entry-values.exp: Ditto. > * gdb.trace/mi-trace-frame-collected.exp: Ditto. > * gdb.trace/mi-trace-unavailable.exp: Ditto. > * gdb.trace/pending.exp: Ditto. > * gdb.trace/report.exp: Ditto. > * gdb.trace/trace-break.exp: Ditto. > * gdb.trace/while-dyn.exp: Ditto. > * gdb.trace/change-loc.h: set_point for powerpc. > * gdb.trace/ftrace.c: Ditto > * gdb.trace/pendshr1.c: Ditto. > * gdb.trace/pendshr2.c: Ditto. > * gdb.trace/range-stepping.c: Ditto. > * gdb.trace/trace-break.c: Ditto. > * gdb.trace/trace-mt.c: Ditto. > * gdb.trace/ftrace.exp: Enable testing for powerpc*-*-*. > (test_ftrace_condition) New function for testing bytecode compilation. Ah, when I said to add new test cases in a separate patch, what I meant was: - use a separate patch (applied *first*) that adds the *new tests* (to be run on existing platforms), i.e. test_ftrace_condition - as part of the patch that actually adds powerpc support, add all the small test case snippets that specifically enable the test cases for powerpc This is again so that each set in a series is meaningful in itself (and does not introduce testsuite regressions when applied alone). > diff --git a/gdb/testsuite/gdb.trace/actions.c b/gdb/testsuite/gdb.trace/actions.c > index 4b7b887..d8538e4 100644 > --- a/gdb/testsuite/gdb.trace/actions.c > +++ b/gdb/testsuite/gdb.trace/actions.c > @@ -46,6 +46,8 @@ static union GDB_UNION_TEST > } gdb_union1_test; > > void gdb_recursion_test (int, int, int, int, int, int, int); > +typedef void (*gdb_recursion_test_fp) (int, int, int, int, int, int, int); > +gdb_recursion_test_fp gdb_recursion_test_ptr = gdb_recursion_test; This is OK, but really needs a comment explaining why it is needed. > +#elif (defined __PPC64__ || defined __PPC__) Use __powerpc64__ and __powerpc__ everywhere. Otherwise looks good. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com