From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118180 invoked by alias); 13 Apr 2015 19:23:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118170 invoked by uid 89); 13 Apr 2015 19:23:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Apr 2015 19:23:02 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3084E8E3E2 for ; Mon, 13 Apr 2015 19:23:01 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3DJN0b2017085 for ; Mon, 13 Apr 2015 15:23:00 -0400 Subject: [PATCH 00/18] Implement full completer limiting From: Keith Seitz To: gdb-patches@sourceware.org Date: Mon, 13 Apr 2015 19:23:00 -0000 Message-ID: <20150413192235.29172.13097.stgit@valrhona.uglyboxes.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00481.txt.bz2 This series of patches is essentially a rewrite of the completion API to enable better/more consistent completion-limiting. Currently completer functions are not required to implement completion- limiting. These functions will compute all possible completions and then rely on complete_line to limit the result. The main goal of this patchset is to require completer functions to implement proper completion-limiting using maybe_add_completion. This actually cleans up the completer API significantly and fixes at least one serious bug (an assertion failure, gdb/17960). The new API requires all completions to be added to the completion list using maybe_add_completion: void my_completer_function (struct completer_data *cdata, struct cmd_list_element *cmd, const char *text, const char *prefix) { while (/* there are more completions to look for */) { char *match = xstrdup (a_completion_match); enum maybe_add_completion_enum add_status; add_status = maybe_add_completion (cdata, match); switch (add_status) { case MAYBE_ADD_COMPLETION_OK: /* Completion was added -- keep looking for more. */ break; case MAYBE_ADD_COMPLETION_OK_MAX_REACHED: /* Completion was added, but now at maximum permitted completions. Stop looking for more matches. */ return; case MAYBE_ADD_COMPLETION_MAX_REACHED: /* Completion was not added; maximum permitted completions already reached. Stop looking for more matches. */ xfree (match); return; case MAYBE_ADD_COMPLETION_DUPLICATE: /* This completion is already in the list. Keep looking for more matches. */ xfree (match); break; } } } Each patch of the set has been tested regression-free against x86_64 linux, native and native-gdbserver. --- Keith Seitz (18): Add struct completer_data to the completion API. Remove completion_tracker_t from the public completion API. Implement completion limiting for complete_on_cmdlist. Implement completion limiting for add_filename_to_list. Implement completion limiting for ada_make_symbol_completion_list. Implement completion limiting for condition_completer. Implement completion limiting for filename_completer. Implement completion limiting for signal_completer. Implement completion limiting for interpreter_completer. Implement completion limiting for cmdpy_completer. Implement completion limiting for reg_or_group_completer. Implement completion limiting for sim_command_completer. Implement completion limiting for complete_on_enum. Implement completion limiting in add_struct_fields. Implement completion limiting for scmcmd_add_completion. Make the completion API completely opaque. Use the hashtable to accumulate completion results. Remove the vector return result from the completion API. gdb/ada-lang.c | 102 +++++- gdb/break-catch-syscall.c | 11 - gdb/breakpoint.c | 36 ++ gdb/cli/cli-cmds.c | 4 gdb/cli/cli-decode.c | 66 +++- gdb/command.h | 17 + gdb/completer.c | 492 ++++++++++++++++++---------- gdb/completer.h | 73 ++-- gdb/corefile.c | 7 gdb/cp-abi.c | 7 gdb/f-lang.c | 8 gdb/guile/scm-cmd.c | 43 +- gdb/infrun.c | 15 - gdb/interps.c | 25 + gdb/language.h | 8 gdb/python/py-cmd.c | 42 ++ gdb/remote-sim.c | 31 ++ gdb/symtab.c | 254 +++++++------- gdb/symtab.h | 47 ++- gdb/testsuite/gdb.ada/complete.exp | 144 ++++++++ gdb/testsuite/gdb.ada/complete/foo.adb | 4 gdb/testsuite/gdb.ada/complete/pck.ads | 12 + gdb/testsuite/gdb.base/break.c | 14 + gdb/testsuite/gdb.base/break.exp | 4 gdb/testsuite/gdb.base/completion.exp | 206 +++++++++++- gdb/testsuite/gdb.base/condbreak.exp | 70 ++++ gdb/testsuite/gdb.base/filesym.c | 4 gdb/testsuite/gdb.base/filesym.exp | 84 +++++ gdb/testsuite/gdb.base/filesym2.c | 24 + gdb/testsuite/gdb.base/filesym3.c | 24 + gdb/testsuite/gdb.base/filesym4.c | 24 + gdb/testsuite/gdb.base/filesym5.c | 22 + gdb/testsuite/gdb.cp/cpcompletion.exp | 55 +++ gdb/testsuite/gdb.cp/pr9594.cc | 28 ++ gdb/testsuite/gdb.guile/scm-cmd.exp | 24 + gdb/testsuite/gdb.python/py-completion.exp | 45 +++ gdb/value.c | 24 + gdb/value.h | 3 38 files changed, 1582 insertions(+), 521 deletions(-) create mode 100644 gdb/testsuite/gdb.base/filesym2.c create mode 100644 gdb/testsuite/gdb.base/filesym3.c create mode 100644 gdb/testsuite/gdb.base/filesym4.c create mode 100644 gdb/testsuite/gdb.base/filesym5.c