On 13 Apr 2015 12:23, Keith Seitz wrote:
> This patch converts sim_command_completer to use maybe_add_completion.

i think you want to push this down into sim/common/sim-options.c ?  otherwise 
you do all of this work only to throw away a good amount of it.

> It does not add any tests, since the `sim' command is highly
> target-dependent and unimplemented for the majority of simulators.

erm, the majority of simulators now have testsuites.  but that doesn't really 
matter because you're updating the gdb part of the API, not the sim side.
-mike