From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120894 invoked by alias); 14 Apr 2015 15:28:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120833 invoked by uid 89); 14 Apr 2015 15:28:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Apr 2015 15:28:40 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 40919340AC0; Tue, 14 Apr 2015 15:28:38 +0000 (UTC) Date: Tue, 14 Apr 2015 15:28:00 -0000 From: Mike Frysinger To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 12/18] Implement completion limiting for sim_command_completer. Message-ID: <20150414152837.GA872@vapier> Mail-Followup-To: Keith Seitz , gdb-patches@sourceware.org References: <20150413192235.29172.13097.stgit@valrhona.uglyboxes.com> <20150413192331.29172.23243.stgit@valrhona.uglyboxes.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20150413192331.29172.23243.stgit@valrhona.uglyboxes.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00530.txt.bz2 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 559 On 13 Apr 2015 12:23, Keith Seitz wrote: > This patch converts sim_command_completer to use maybe_add_completion. i think you want to push this down into sim/common/sim-options.c ? otherwi= se=20 you do all of this work only to throw away a good amount of it. > It does not add any tests, since the `sim' command is highly > target-dependent and unimplemented for the majority of simulators. erm, the majority of simulators now have testsuites. but that doesn't real= ly=20 matter because you're updating the gdb part of the API, not the sim side. -mike --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBCAAGBQJVLTIlAAoJEEFjO5/oN/WBoVQP+O4t1kg7265+K7QbUZFIpCec OTIOLGKzM503PDj2PECe33/QILeqme8fxSoK2DxIlkAPZtCP7ZyOkddBtBqoIUBA zNk12S+M+8rxOCiYbzyTBQUl7mFcIyWb3H4Yb88dsgxGtat1KM1br1yLGd7GI02m EEr4nl7lMSc3uSi5UoycrUiAn9rdVcTKavC9sd7tyFBv2NeHDYeYfkLJi9qyTNb+ R6Q9UX8lNnZwv53H0jTJ6oG9X1/kxWmrMOn6Xf1PvRJOytThZCywhQJSGVe9yzm9 A/JWO9hns5TndCjeZj3O73ZbMzw+ZEYxWSdJUyHD98CHo/8izDJQ2cBTlH6pVpIS 4npY6RiF1Pc4TovQXYitX+bMt5LMqjQ1ZNTAWQErLmKBB34aEdhSFjdS1WWfViBh iD+HhdRrsilXIWE3J5mPvQToJTlGYDcn6xTSS29+2h9gVWdUiVqtFCGi/VkjgyZi Hk+UUvpQQACr0KWqOpRnW1sOqvlNCCf4s4hV5f1IcHQXyZsiXNfYGvSDUD03zDki gckeuavDRPXI6TMyNidNwG1KzqhFQubKrQsdzVDkQtjt5AdvCk6Q0+xQPqE3g82c +wZ13M95ceaJLe6MT9q63Kugyfx1vfSCNSZlGv9e4DR5bVDigm7J6TBiougw+CK4 G/nx1GpOnIgeZpQo0Fk= =QJP9 -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--