From: Mike Frysinger <vapier@gentoo.org>
To: Jiri Gaisler <jiri@gaisler.se>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5 2/9] sim/erc32: Use gdb callback for UART I/O when linked with gdb.
Date: Sun, 19 Apr 2015 06:39:00 -0000 [thread overview]
Message-ID: <20150419063926.GB17952@vapier> (raw)
In-Reply-To: <1428093356-7296-3-git-send-email-jiri@gaisler.se>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On 03 Apr 2015 22:35, Jiri Gaisler wrote:
> * erc32 (init_sim, port_init, read_uart, write_uart, flush_uart, uarta_tx,
"erc32.c"
> uartb_tx, uart_rx): Use gdb callbacks for console I/O.
i'm seeing more updates to the global scope. you need to mention each change --
include files added/removed, vars added/removed, etc...
> * func.c: declare host callback structure
missing (xxx)
> * interf.c (run_sim): add -nouartrx switch to disable UART input.
missing sim_callback
> * sis.h: declare host callback structure
need to document each new var/struct
> +int dumbio = 0; /* normal, smart, terminal oriented IO by default */
un-inline it, and fix up the comment style. it also isn't exactly clear ...
make it a declarative statement:
/* Use a non-dumb (normal, smart) terminal I/O by default. */
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-19 6:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 20:36 [PATCH v5 0/9] Update of the SPARC SIS simulator Jiri Gaisler
2015-04-03 20:36 ` [PATCH v5 8/9] sim/erc32: Add data watchpoint support Jiri Gaisler
2015-04-19 7:04 ` Mike Frysinger
2015-04-03 20:36 ` [PATCH v5 9/9] Add watchpoint support to gdb simulator interface Jiri Gaisler
2015-04-03 20:36 ` [PATCH v5 1/9] sim/erc32: Switched emulated memory to host endian order Jiri Gaisler
2015-04-19 6:35 ` Mike Frysinger
2015-04-03 20:36 ` [PATCH v5 7/9] sim/erc32: Updated documentation Jiri Gaisler
2015-04-03 20:36 ` [PATCH v5 6/9] sim/erc32: Add support for LEON2 processor emulation Jiri Gaisler
2015-04-19 6:56 ` Mike Frysinger
2015-04-03 20:36 ` [PATCH v5 2/9] sim/erc32: Use gdb callback for UART I/O when linked with gdb Jiri Gaisler
2015-04-19 6:39 ` Mike Frysinger [this message]
2015-04-03 20:36 ` [PATCH v5 5/9] sim/erc32: Add support for LEON3 processor emulation Jiri Gaisler
2015-04-19 6:54 ` Mike Frysinger
2015-04-03 20:36 ` [PATCH v5 3/9] sim/erc32: Access memory subsystem through struct memsys Jiri Gaisler
2015-04-19 6:44 ` Mike Frysinger
2015-04-03 20:36 ` [PATCH v5 4/9] sim/erc32: Move local extern declarations into sis.h Jiri Gaisler
2015-04-19 6:46 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150419063926.GB17952@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=jiri@gaisler.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).