From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6798 invoked by alias); 19 Apr 2015 06:39:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6778 invoked by uid 89); 19 Apr 2015 06:39:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 19 Apr 2015 06:39:29 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 76838340D7A; Sun, 19 Apr 2015 06:39:27 +0000 (UTC) Date: Sun, 19 Apr 2015 06:39:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 2/9] sim/erc32: Use gdb callback for UART I/O when linked with gdb. Message-ID: <20150419063926.GB17952@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1428093356-7296-1-git-send-email-jiri@gaisler.se> <1428093356-7296-3-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline In-Reply-To: <1428093356-7296-3-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00718.txt.bz2 --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 826 On 03 Apr 2015 22:35, Jiri Gaisler wrote: > * erc32 (init_sim, port_init, read_uart, write_uart, flush_uart, uarta_t= x, "erc32.c" > uartb_tx, uart_rx): Use gdb callbacks for console I/O. i'm seeing more updates to the global scope. you need to mention each chan= ge --=20 include files added/removed, vars added/removed, etc... > * func.c: declare host callback structure missing (xxx) > * interf.c (run_sim): add -nouartrx switch to disable UART input. missing sim_callback > * sis.h: declare host callback structure need to document each new var/struct > +int dumbio =3D 0; /* normal, smart, terminal oriented IO by default */ un-inline it, and fix up the comment style. it also isn't exactly clear ... make it a declarative statement: /* Use a non-dumb (normal, smart) terminal I/O by default. */ -mike --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVM02eAAoJEEFjO5/oN/WBE5AQAJoEdLRiZbGZ+GXSbb/8QpZM VEc9ZvRN+qWR05ESJv/U8FY504U65Nbv/yPQnzUfHHVR37TVOFJ2ll3PehkyflUO V136eZQ0X6L7ek0LiXB1N8QGWdju3IG0V0r+U69X447WKKPB/oahl66+gN82TIsF q3JSOahkcjVyBdEdTd3XKTHTWYKH7YoGewS6SHg6TSQOTrWpVlJXlTfvSimtU1Ud SPGuRHNwWlsCSlPW5CGix9OZMSAIIlWIba44iuLlsT0pAddTr97ZxcdHaxVcIblq zgrqkp6DOlVfO9Z7a2FHpOUQ7BxvaHjRW1hgVGU7mgjyD3zsaf5mySIOtZgyX6y4 Q7GRX6If4hEOc2SuvtuzFSjs+IPzL3Cfrl3De8/mD+0mcvUraOZqT4QxNHeIb6Jb b9/L5mVZp/2MhC25JY7dq9v6SI9JXM+LuvyNGP4mnTuFeIWkScWAISnuJwdbDpFO wcqG2xYd+enloKsL07P2hVOA5Vmqb3zfBKzpMIIsNuV4qt9Wc5wzUrbtowDhlmBM ked19e0sEQHDpHpkKetMPLDShn25bWffIPv6Pj0YSPBPRf8RKLRT9OSmCZrkkh5s oNwPXiVfnSxbS2Rml3BY/ChxOyZgvN4xRK19Jq7HZ5XjbxqRNXZ4u4hBAf8uDC4G f9JoGiNK2ZvkCx5b+qXz =KMCc -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd--