From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12147 invoked by alias); 19 Apr 2015 06:46:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10101 invoked by uid 89); 19 Apr 2015 06:45:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 19 Apr 2015 06:45:21 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id E7FAB340DAF; Sun, 19 Apr 2015 06:45:19 +0000 (UTC) Date: Sun, 19 Apr 2015 06:46:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 4/9] sim/erc32: Move local extern declarations into sis.h. Message-ID: <20150419064518.GD17952@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1428093356-7296-1-git-send-email-jiri@gaisler.se> <1428093356-7296-5-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u65IjBhB3TIa72Vp" Content-Disposition: inline In-Reply-To: <1428093356-7296-5-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00720.txt.bz2 --u65IjBhB3TIa72Vp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 341 On 03 Apr 2015 22:35, Jiri Gaisler wrote: > * erc32.c : Move extern declarations to sis.h > * exec.c, func.c, interf.c, sis.c : As above. > * sis.h : Add extern declarations patch looks fine, but this needs to be filled out a lot more, and: - each file should be listed on a line by itself w/a leading * - no spaces before the : -mike --u65IjBhB3TIa72Vp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVM07+AAoJEEFjO5/oN/WBswYP/2YjXbje9m+91M1wpefl91aS QTO+xMSptkjImVNTlQlzswKx+zEsSzJx2D0nQswW8B1rw/uZsWL+kKyKPsvcWbvN 2geLcCZfHkc+Oom1XqowZxkHGgwIr3q788hkf7gnV1vlX1OtJTJFroI7oWYyZQQO Td5/6Lbyzi70Cjg1fivC/CROg5+kOp+KXUq4qB402iSP5lG8ZVGRXpBinM3rdb0i ZgXGXwPWuqEkb357SkRk4l/DuMOiIcjMYvmte7Rqvq5h9RkQwD2exUff7919Kfzy 6yMw41u3fIuavCHjdl6r4ksk9rk6XrTJIvFitvzswGKEtKmfaMvV3FRkJH90mgNu XjlDOHaMivmu3Pz+7NDePveRveY1FViIxKPBVGSD3gfJ3MMuBA0MRRKYyBcqynhE MoHRFhSWSNDXwh6NVTZ3sjG8meLZYzD7jYfXbiLzvGJmQtX81JpGD+sNMPn7G9iw oMxwZs54JLAUfkO7CUOyzIogUqOTmUL+6JvnMvJyoqUCD1hor6sBS2wJvxxbWnSc cagBvEhDKVbdCXjlZiKa8P/HUvkMeTBDdYoQw3gdlyFwhvGFIaq3r9msdVjEsTeD 3yZAipJCtJ45OhAaH3ykDDvYrom3c4YIjXTl23CRPcZMvCyuwkdsJqCu3TImniCc QH+KyrBcPhlkGwJMdBtw =dwEb -----END PGP SIGNATURE----- --u65IjBhB3TIa72Vp--