From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54904 invoked by alias); 19 Apr 2015 07:04:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46084 invoked by uid 89); 19 Apr 2015 07:03:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 19 Apr 2015 06:59:55 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 91605340E0C; Sun, 19 Apr 2015 06:59:53 +0000 (UTC) Date: Sun, 19 Apr 2015 07:04:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 8/9] sim/erc32: Add data watchpoint support. Message-ID: <20150419065952.GG17952@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1428093356-7296-1-git-send-email-jiri@gaisler.se> <1428093356-7296-9-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gm5TwAJMO0F2iVRz" Content-Disposition: inline In-Reply-To: <1428093356-7296-9-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00723.txt.bz2 --gm5TwAJMO0F2iVRz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 634 On 03 Apr 2015 22:35, Jiri Gaisler wrote: > * exec.c (wpmask): New function to calculate address mask. > (dispatch_instruction): send WPT_TRAP when breakpoint is hit. Check on capitialize sentences -- "Send" here. comes up multiple times. > +static unsigned char > +wpmask (uint32 op3) > +{ > + switch (op3 & 3) { > + case 0: return 3; /* word */ > + case 1: return 0; /* byte */ > + case 2: return 1; /* half-word */ > + case 3: return 7; /* double word */ > + } > +} indentation needs fixing > +int > +check_wpw(struct pstate *sregs, int32 address, unsigned char mask) space before the ( -mike --gm5TwAJMO0F2iVRz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVM1JoAAoJEEFjO5/oN/WBkqgP/2ZWEVsoXrnDa13ONX74Hd37 KF5UA9/ZDUoSVFXSTZX+iHNEbjZwJjaCnP4bRPhgIDpuV2Vgy6VI59haL3zopeNr ofnmNWecYXhyYZDAWsA4VQ38jeyHbV1dW7OaNibW+Vkjk3kdCjip5KIWTfXeUmw+ Z2wW5FKckKp/ysfNi/zKuf8CCRs38uPnstimVub2EGr/7HXegO8QaB5/Y095f2iz 3tJ7nwm3kZ0/Sxd0nD78qmlndbonk+eAyYiqGqXTYeeBuNdetJ2zoU1xXz9PiW74 4pfTfqQlfjkopY3efYW8fsIySFvca3Cdp6cODIUcgtkYo8Wa8SLi8tREMPAY1GhV yDZD/qOVnhn4oFNI44E7xWO3rXLWHiB2b2UMFT0zTYn82sa8E8mEieUAWAj7kX6F lFoOmtL0dyAIQM4RgrDsG1EiTdr2jYF4j5sZZTlnJ2vLfbrImLbSdEM18l/f6Zn4 HI5dN5aq9H0RT7d5Z4ZJMCrYFZAnMSfSAVWiMdjTttL0uvFy9+loCpyIu4ccg8eo JgxwCfxNPjanXm/iwARKnbghY563v/PcdR588h4PDVLYZH3B0aYtWf3YVlSiE8i/ hb6pmU/Tc32Az88lrS6Ao4xGiGrvvx3gTpyCY1Vpg/SsZZVjGeX/tNOCIcmUDE4l ZnijNYbMqVNDe9X1SJXY =GfLf -----END PGP SIGNATURE----- --gm5TwAJMO0F2iVRz--