From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91026 invoked by alias); 24 Apr 2015 16:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91015 invoked by uid 89); 24 Apr 2015 16:49:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 24 Apr 2015 16:49:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AB506116445; Fri, 24 Apr 2015 12:49:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1U20mmU8Eq7K; Fri, 24 Apr 2015 12:49:07 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7C70C116357; Fri, 24 Apr 2015 12:49:07 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5550540EAD; Fri, 24 Apr 2015 09:49:09 -0700 (PDT) Date: Fri, 24 Apr 2015 16:49:00 -0000 From: Joel Brobecker To: Patrick Palka Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Update our idea of our terminal's dimensions even outside of TUI Message-ID: <20150424164909.GO4764@adacore.com> References: <1429836801-14218-1-git-send-email-patrick@parcs.ath.cx> <1429836801-14218-2-git-send-email-patrick@parcs.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429836801-14218-2-git-send-email-patrick@parcs.ath.cx> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-04/txt/msg00943.txt.bz2 > When in the CLI, GDB's "width" and "height" variables are not kept in sync > when the underlying terminal gets resized. > > This patch fixes this issue by making sure sure to update GDB's "width" > and "height" variables in the !tui_active case of our SIGWINCH handler. > > gdb/ChangeLog: > > * tui/tui-win.c (tui_sigwinch_handler): Remove now-stale comment. > (tui_sigwinch_handler): Still update our idea of > the terminal's width and height even when TUI is not active. Neat. Thanks for this nice little enhancement! I've only glanced at the patch, as I'm not a specialist of this area and Pedro has been pretty active there and would do a much better job than I would. But if Pedro can't make it, I'm sure I could set some time aside to review it a little more carefully. -- Joel