From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70459 invoked by alias); 27 Apr 2015 14:42:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70446 invoked by uid 89); 27 Apr 2015 14:42:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 14:42:29 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 69BAC2BB3A0; Mon, 27 Apr 2015 14:42:28 +0000 (UTC) Received: from blade.nx (ovpn-116-91.ams2.redhat.com [10.36.116.91]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3REgRO3023926; Mon, 27 Apr 2015 10:42:28 -0400 Received: by blade.nx (Postfix, from userid 1000) id 8743B263C9B; Mon, 27 Apr 2015 15:42:26 +0100 (BST) Date: Mon, 27 Apr 2015 14:42:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Do not manipulate "target:" filenames as local paths Message-ID: <20150427144226.GB24077@blade.nx> References: <20150414114129.GB4660@blade.nx> <1429085001-25894-1-git-send-email-gbenson@redhat.com> <21818.38520.332957.849560@ruffy2.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21818.38520.332957.849560@ruffy2.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00990.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > > > This patch alters two places that manipulate object file filenames > > to detect "target:" filenames and to not attempt to manipulate them > > as paths on the local filesystem: > > > > - allocate_objfile is updated to not attempt to expand "target:" > > filenames with gdb_abspath. > > > > - load_auto_scripts_for_objfile is updated to not attempt to load > > auto-load scripts for object files with "target:" filenames. > > > > Built and regtested on RHEL6.6 x86_64. > > > > Ok to commit? > > > > gdb/ChangeLog: > > > > * objfiles.c (allocate_objfile): Do not attempt to expand name > > if name is a "target:" filename. > > * auto-load.c (load_auto_scripts_for_objfile): Do not attempt > > to load auto-load scripts for objfiles with "target:" filenames. > > Thanks for the ping. > > LGTM. Thanks Doug, I pushed it. Cheers, Gary -- http://gbenson.net/