From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102594 invoked by alias); 4 May 2015 09:11:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102582 invoked by uid 89); 4 May 2015 09:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: mail3-relais-sop.national.inria.fr Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 04 May 2015 09:11:25 +0000 Received: from skagos.loria.fr ([152.81.7.251]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA; 04 May 2015 11:11:12 +0200 Date: Mon, 04 May 2015 09:11:00 -0000 From: Gabriel Corona To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use a shell command as a socket for gdbserver Message-ID: <20150504091107.GA5953@skagos.loria.fr> References: <1430606377-16456-1-git-send-email-gabriel.corona@enst-bretagne.fr> <20150504074434.GE30924@vapier> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150504074434.GE30924@vapier> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00042.txt.bz2 Hello, Thanks, I'll fix that. The other patch (Make gdbserver connect to SOCK_STREAM sockets) has similar formatting issues that I'll fix as well. > shouldn't you close sockets[1] after the dup2 ? Indeed I forgot to close it. -- Gabriel