[PATCH v2 1/3] Fix MPX tests for path changes.

[PATCH v2 1/3] Fix MPX tests for path changes.

[Walfred Tedeschi]

Joel,

Next three patches are about fixing the test compilations and
improvement of the test for MPX registers.

Followed yor indications.

Thanks again and best regards,
-Fred


Changes on the path for i386-cpuid.h file lead to failure in compiling
tests for MPX have to be changed.

2014-08-12  Walfred Tedeschi  <walfred.tedeschi@intel.com>

gdb/testsuite
	* gdb.arch/i386-mpx.c: Change path in include file.
	* gdb.arch/i386-mpx.exp: Change include dir path
	compilation flag.

---
 gdb/testsuite/gdb.arch/i386-mpx.c   | 3 ++-
 gdb/testsuite/gdb.arch/i386-mpx.exp | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/i386-mpx.c b/gdb/testsuite/gdb.arch/i386-mpx.c
index 8e5096d..e151ea6 100644
--- a/gdb/testsuite/gdb.arch/i386-mpx.c
+++ b/gdb/testsuite/gdb.arch/i386-mpx.c
@@ -18,7 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include <stdio.h>
-#include "nat/x86-cpuid.h"
+#include "x86-cpuid.h"
+
 
 #ifndef NOINLINE
 #define NOINLINE __attribute__ ((noinline))
diff --git a/gdb/testsuite/gdb.arch/i386-mpx.exp b/gdb/testsuite/gdb.arch/i386-mpx.exp
index 5ed89da..b7078e7 100644
--- a/gdb/testsuite/gdb.arch/i386-mpx.exp
+++ b/gdb/testsuite/gdb.arch/i386-mpx.exp
@@ -22,10 +22,10 @@ if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
 
 standard_testfile
 
-set comp_flags "-fmpx -I${srcdir}/../common"
+set comp_flags "-fmpx -I${srcdir}/../nat/"
 
 if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
- [list debug nowarnings additional_flags=${comp_flags}]] } {
+     [list debug nowarnings additional_flags=${comp_flags}]] } {
     return -1
 }
 
-- 
2.1.0

Re: [PATCH v2 1/3] Fix MPX tests for path changes.

[Joel Brobecker]

> Changes on the path for i386-cpuid.h file lead to failure in compiling
> tests for MPX have to be changed.
> 
> 2014-08-12  Walfred Tedeschi  <walfred.tedeschi@intel.com>
> 
> gdb/testsuite
> 	* gdb.arch/i386-mpx.c: Change path in include file.
> 	* gdb.arch/i386-mpx.exp: Change include dir path
> 	compilation flag.

OK to push.

One minor comment below, FYI.

> ---
>  gdb/testsuite/gdb.arch/i386-mpx.c   | 3 ++-
>  gdb/testsuite/gdb.arch/i386-mpx.exp | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/i386-mpx.c b/gdb/testsuite/gdb.arch/i386-mpx.c
> index 8e5096d..e151ea6 100644
> --- a/gdb/testsuite/gdb.arch/i386-mpx.c
> +++ b/gdb/testsuite/gdb.arch/i386-mpx.c
> @@ -18,7 +18,8 @@
>     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>  
>  #include <stdio.h>
> -#include "nat/x86-cpuid.h"
> +#include "x86-cpuid.h"
> +
>  
>  #ifndef NOINLINE
>  #define NOINLINE __attribute__ ((noinline))
> diff --git a/gdb/testsuite/gdb.arch/i386-mpx.exp b/gdb/testsuite/gdb.arch/i386-mpx.exp
> index 5ed89da..b7078e7 100644
> --- a/gdb/testsuite/gdb.arch/i386-mpx.exp
> +++ b/gdb/testsuite/gdb.arch/i386-mpx.exp
> @@ -22,10 +22,10 @@ if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
>  
>  standard_testfile
>  
> -set comp_flags "-fmpx -I${srcdir}/../common"
> +set comp_flags "-fmpx -I${srcdir}/../nat/"
>  
>  if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
> - [list debug nowarnings additional_flags=${comp_flags}]] } {
> +     [list debug nowarnings additional_flags=${comp_flags}]] } {
>      return -1

We normally avoid mixing pure formatting changes together with
other changes. It's not worth splitting this patch, but in the
future, formatting changes are considered "obvious" and as such
can be pushed without prior approval.

>  }
>  
> -- 
> 2.1.0

-- 
Joel