From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68785 invoked by alias); 6 May 2015 18:54:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68774 invoked by uid 89); 6 May 2015 18:54:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 May 2015 18:54:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3536E286A8; Wed, 6 May 2015 14:54:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hELoGDY9duLj; Wed, 6 May 2015 14:54:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0533A286A2; Wed, 6 May 2015 14:54:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id ABABB40EAD; Wed, 6 May 2015 11:54:27 -0700 (PDT) Date: Wed, 06 May 2015 18:54:00 -0000 From: Joel Brobecker To: Walfred Tedeschi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/3] Fix MPX tests for path changes. Message-ID: <20150506185427.GG5186@adacore.com> References: <1429791214-27609-1-git-send-email-walfred.tedeschi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429791214-27609-1-git-send-email-walfred.tedeschi@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-05/txt/msg00123.txt.bz2 > Changes on the path for i386-cpuid.h file lead to failure in compiling > tests for MPX have to be changed. > > 2014-08-12 Walfred Tedeschi > > gdb/testsuite > * gdb.arch/i386-mpx.c: Change path in include file. > * gdb.arch/i386-mpx.exp: Change include dir path > compilation flag. OK to push. One minor comment below, FYI. > --- > gdb/testsuite/gdb.arch/i386-mpx.c | 3 ++- > gdb/testsuite/gdb.arch/i386-mpx.exp | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/i386-mpx.c b/gdb/testsuite/gdb.arch/i386-mpx.c > index 8e5096d..e151ea6 100644 > --- a/gdb/testsuite/gdb.arch/i386-mpx.c > +++ b/gdb/testsuite/gdb.arch/i386-mpx.c > @@ -18,7 +18,8 @@ > along with this program. If not, see . */ > > #include > -#include "nat/x86-cpuid.h" > +#include "x86-cpuid.h" > + > > #ifndef NOINLINE > #define NOINLINE __attribute__ ((noinline)) > diff --git a/gdb/testsuite/gdb.arch/i386-mpx.exp b/gdb/testsuite/gdb.arch/i386-mpx.exp > index 5ed89da..b7078e7 100644 > --- a/gdb/testsuite/gdb.arch/i386-mpx.exp > +++ b/gdb/testsuite/gdb.arch/i386-mpx.exp > @@ -22,10 +22,10 @@ if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } { > > standard_testfile > > -set comp_flags "-fmpx -I${srcdir}/../common" > +set comp_flags "-fmpx -I${srcdir}/../nat/" > > if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \ > - [list debug nowarnings additional_flags=${comp_flags}]] } { > + [list debug nowarnings additional_flags=${comp_flags}]] } { > return -1 We normally avoid mixing pure formatting changes together with other changes. It's not worth splitting this patch, but in the future, formatting changes are considered "obvious" and as such can be pushed without prior approval. > } > > -- > 2.1.0 -- Joel