From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71704 invoked by alias); 7 May 2015 06:36:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71685 invoked by uid 89); 7 May 2015 06:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 May 2015 06:36:17 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 13D42340ECC; Thu, 7 May 2015 06:36:14 +0000 (UTC) Date: Thu, 07 May 2015 06:36:00 -0000 From: Mike Frysinger To: Nicholas Clifton Cc: Hans-Peter Nilsson , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: Fix sim fallout from arm assembler complaining about symbols named as insns Message-ID: <20150507063614.GZ30924@vapier> Mail-Followup-To: Nicholas Clifton , Hans-Peter Nilsson , gdb-patches@sourceware.org, binutils@sourceware.org References: <201505020017.t420Hn09026225@ignucius.se.axis.com> <5549EEDC.7040707@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XUd+PsnCfaVdInSg" Content-Disposition: inline In-Reply-To: <5549EEDC.7040707@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00133.txt.bz2 --XUd+PsnCfaVdInSg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1710 On 06 May 2015 11:37, Nicholas Clifton wrote: > Hi Hans-Peter, >=20 > > I'm not completely sure this new gas warning is a good thing. > > I mean, symbols such as those below don't really interfere with > > the insn namespace, do they? >=20 > No, but they can be a little bit confusing and the problem I was trying=20 > to solve, of an instruction name being mistakenly treated as a symbol,=20 > is genuine. It would be better I agree to restrict this check to just=20 > the case where the "=3D" assignment operator is being used, but I did not= =20 > want to modify generic code. Maybe I should have done that. :-( >=20 >=20 > > To wit, right now, the new symbol "sanity-check" causes failures > > for --target arm-eabi check-sim: >=20 > So it does. I should have checked that before committing the patch. Sor= ry. >=20 >=20 > > +2015-05-02 Hans-Peter Nilsson > > + > > + * bl.cgs (bl0): Rename from symbol colliding with insn name bl. > > + * iwmmxt/tmia.cgs (tmia0): Similar. > > + * iwmmxt/tmiaph.cgs (tmiaph0): Similar. > > + * iwmmxt/waligni.cgs (waligni0): Similar. > > + * iwmmxt/wand.cgs (wand0): Similar. > > + * iwmmxt/wandn.cgs (wandn0): Similar. > > + * iwmmxt/wmov.cgs (wmov0): Similar. > > + * iwmmxt/wor.cgs (wor0): Similar. > > + * iwmmxt/wshufh.cgs (wshuf0): Similar. > > + * iwmmxt/wxor.cgs (wxor0): Similar. > > + * iwmmxt/wzero.cgs (wzero0): Similar. > > + * xscale/mia.cgs (mia0): Similar. > > + * xscale/miaph.cgs (miaph0): Similar. >=20 > I think that this is a good solution - please apply. so people can't have a global variable named "bl" now ? or "ldr" ? that=20 doesn't seem like the right direction in which case this patch isn't really= =20 needed ... -mike --XUd+PsnCfaVdInSg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVSwfeAAoJEEFjO5/oN/WBowoP/jprqCIxunoztealgv6encuO ndRvG40i2pHKr6meiLA0I8Yd9NwAtstlAW2npEQIFDSDReSXkK03epQ8B9+cCPoL l2gIMnPdm4wHno6n7rt81idRsMgRCaE4EN8t5/BWHtiWj5stnRq20wX5dQgrRZ13 WgNJweWXfVqkoq1mcIZ1th5zeliCzfB0g6HW6Ahu5kcQKPDbAk32R1oABISTmzqN rtZtHO/738xYkoSYupNlrKD/1fcfbcL7OHjhUOCNQF5zhkuGUzBuNEFtEo5HyMJa qHWcD5CbaSjFpqFwRgtzg/mNrhcEi98gYH1TOIWmp+b5Id5aOx7EAorspBiAESNJ EMqqec69T9aKmFNZVyvrm9C4CxkGPWuTIaisC1/FgsMnov3k+vHn3M4n4j5k7muo MjuRVRxrMIMc6YT2ex1A4ToESMRhk7FFkPMWKbB1yeOQYFAe4O045WPXegGtBuLB aRMN+a8PHhbgXc8Kc7iE9dWq6muRxHCf9kmNDuiDX2W6hbvco/NWNLhoIHD0UZ1L zRQ+KHcmhUF8t3BAjxAJ22PsBlXHalYlagyMbsE2TB5em1e9vtkShwRBdWs1dcJq /S4bUkbGiDjwoH0zInDBxEoga7I/C4cLciAmAtn4W8MUiMIBHSYB5y2tQVtMR67H FyLhP6E04AvNW2zMopaU =H5SL -----END PGP SIGNATURE----- --XUd+PsnCfaVdInSg--