From: Joel Brobecker <brobecker@adacore.com>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's
Date: Mon, 11 May 2015 20:55:00 -0000 [thread overview]
Message-ID: <20150511205541.GF4767@adacore.com> (raw)
In-Reply-To: <554CFF15.1090206@codesourcery.com>
> On 05/08/2015 02:28 PM, Joel Brobecker wrote:
> >>gdb/ChangeLog:
> >>
> >>2015-05-07 Luis Machado <lgustavo@codesourcery.com>
> >>
> >> * gdb/mi/mi-cmd-var.c (mi_parse_format): Handle new "zero-hexadecimal"
> >> format.
> >> * gdb/varobj.c (varobj_format_string): Add "zero-hexadecimal" entry.
> >> (format_code): Add 'z' entry.
> >> (varobj_set_display_format): Handle FORMAT_ZHEXADECIMAL.
> >> * gdb/varobj.h (varobj_display_formats) <FORMAT_ZHEXADECIMAL>: New enum
> >> field.
> >
> >I don't normally have authority to approve, but the patch looks
> >sufficiently mechanical that I think I can provide approval if
> >the area maintainer isn't available.
[...]
> I've updated the patch with your suggestions now.
Thanks, Luis. FWIW, the patch looks good to me. Let's wait one more
week for the MI maintainer to give any feedback, but otherwise just
go ahead and push (based on the fact that it's fairly consistent with
what we already have, and a fairly mechanical change).
--
Joel
next prev parent reply other threads:[~2015-05-11 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 17:37 [PATCH v2 0/3] varobj zero-padded hexadecimal format Luis Machado
2015-05-07 17:37 ` [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's Luis Machado
2015-05-08 17:28 ` Joel Brobecker
2015-05-08 18:23 ` Luis Machado
2015-05-11 20:55 ` Joel Brobecker [this message]
2015-05-20 12:16 ` Luis Machado
2015-05-25 23:39 ` Luis Machado
2015-05-07 17:37 ` [PATCH v2 2/3] Add varobj zero-hexadecimal format tests Luis Machado
2015-05-08 17:30 ` Joel Brobecker
2015-05-07 17:37 ` [PATCH v2 3/3] Documentation changes for the new zero-hexadecimal format Luis Machado
2015-05-07 18:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511205541.GF4767@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).