From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: [commit] [PATCH v5 1/7] compile: Add one debug message
Date: Sat, 16 May 2015 12:19:00 -0000 [thread overview]
Message-ID: <20150516121946.GA22586@host1.jankratochvil.net> (raw)
In-Reply-To: <5556238B.3050808@redhat.com>
On Fri, 15 May 2015 18:49:15 +0200, Pedro Alves wrote:
> On 05/13/2015 09:16 PM, Jan Kratochvil wrote:
>
> > diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c
> > index fe23448..745d787 100644
> > --- a/gdb/compile/compile-object-load.c
> > +++ b/gdb/compile/compile-object-load.c
> > @@ -580,6 +580,12 @@ compile_object_load (const char *object_file, const char *source_file)
> > TYPE_LENGTH (regs_type),
> > GDB_MMAP_PROT_READ);
> > gdb_assert (regs_addr != 0);
> > + if (compile_debug)
> > + fprintf_unfiltered (gdb_stdout,
> > + "allocated %s bytes at %s for registers\n",
> > + paddress (target_gdbarch (),
> > + TYPE_LENGTH (regs_type)),
> > + paddress (target_gdbarch (), regs_addr));
> > store_regs (regs_type, regs_addr);
> > }
> >
>
> Please send debug output to gdb_stdlog. OK with that change.
OK but gdb/compile/ is using now only gdb_stdout; the error above is due to
a copy-paste. So I will send a follow-up patch to change all the other
gdb/compile/ gdb_stdout strings to gdb_stdlog.
Checked in:
b6de3f9642c58439c31690255c3a4326728da88d
Jan
next prev parent reply other threads:[~2015-05-16 12:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 20:16 [PATCH v5 0/7] compile: compile print (&unmap) Jan Kratochvil
2015-05-13 20:16 ` [PATCH v5 3/7] compile: Distribute scope, add scope_data Jan Kratochvil
2015-05-15 16:49 ` Pedro Alves
2015-05-16 12:39 ` [commit] " Jan Kratochvil
2015-05-13 20:16 ` [PATCH v5 4/7] compile: Use -Wall, not -w Jan Kratochvil
2015-05-15 16:49 ` Pedro Alves
2015-05-16 12:43 ` [commit] " Jan Kratochvil
2015-05-13 20:16 ` [PATCH v5 1/7] compile: Add one debug message Jan Kratochvil
2015-05-15 16:49 ` Pedro Alves
2015-05-16 12:19 ` Jan Kratochvil [this message]
2015-05-16 13:09 ` [patch] compile: gdb_stdout -> gdb_stdlog [compile: Add one debug message] Jan Kratochvil
2015-05-19 11:47 ` Pedro Alves
2015-05-19 12:28 ` [commit] " Jan Kratochvil
2015-05-13 20:16 ` [PATCH v5 2/7] Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-05-16 12:27 ` [commit] " Jan Kratochvil
2015-05-13 20:17 ` [PATCH v5 7/7] RFC only: compile: Use also inferior munmap Jan Kratochvil
2015-05-13 20:17 ` [PATCH v5 5/7] Code cleanup: compile: func_addr -> func_sym Jan Kratochvil
2015-05-15 16:51 ` Pedro Alves
2015-05-16 12:45 ` [commit] " Jan Kratochvil
2015-05-13 20:17 ` [PATCH v5 6/7] compile: New 'compile print' Jan Kratochvil
2015-05-15 17:04 ` Pedro Alves
2015-05-16 12:58 ` [commit] " Jan Kratochvil
2015-05-16 13:39 ` [commit#2] " Jan Kratochvil
2015-05-16 14:25 ` [commit] " Patrick Palka
2015-05-16 14:39 ` [obv] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516121946.GA22586@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).