From: Joel Brobecker <brobecker@adacore.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Prune duplicate command history entries
Date: Wed, 03 Jun 2015 17:10:00 -0000 [thread overview]
Message-ID: <20150603170959.GB2801@adacore.com> (raw)
In-Reply-To: <20150603082036.GR17330@embecosm.com>
> > This patch implements pruning of duplicate command-history entries using
> > a modest amount of lookbehind. The motivation for this patch is to
> > reduce the prevalence of basic commands such as "up" and "down" in the
> > history file.
>
> Dropping commands such as up / down could be pretty annoying if you
> wanted to figure out where you were in the past. Dropping things like
> bt from the history would be less annoying.
I guess it's a question of preference, then. I know that my shell
merges all duplicate commands into one when it comes to the history,
and I really appreciate that feature. A Lot.
> I wonder if we should classify commands into navigation or
> state-changing commands and diagnostic commands.
> I'd be happier see repeated diagnostic commands disappear, and less so
> for commands that change inferior state, or navigate me around the
> stack.
FWIW, I'd find that distinction a little too complex for the gains
we're trying to achieve. At most, I'd just suggest one toggle to
activate duplicate merging or not. Just my 2 cents.
--
Joel
prev parent reply other threads:[~2015-06-03 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 3:22 Patrick Palka
2015-06-03 8:20 ` Andrew Burgess
2015-06-03 14:16 ` Patrick Palka
2015-06-03 17:42 ` Andrew Burgess
2015-06-03 17:10 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603170959.GB2801@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).