From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12920 invoked by alias); 3 Jun 2015 17:10:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12893 invoked by uid 89); 3 Jun 2015 17:10:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Jun 2015 17:10:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 998D528B09; Wed, 3 Jun 2015 13:10:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DcpXjunHj22x; Wed, 3 Jun 2015 13:10:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7354628815; Wed, 3 Jun 2015 13:10:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CFD97406D3; Wed, 3 Jun 2015 10:09:59 -0700 (PDT) Date: Wed, 03 Jun 2015 17:10:00 -0000 From: Joel Brobecker To: Andrew Burgess Cc: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Prune duplicate command history entries Message-ID: <20150603170959.GB2801@adacore.com> References: <1433301766-20101-1-git-send-email-patrick@parcs.ath.cx> <20150603082036.GR17330@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603082036.GR17330@embecosm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00043.txt.bz2 > > This patch implements pruning of duplicate command-history entries using > > a modest amount of lookbehind. The motivation for this patch is to > > reduce the prevalence of basic commands such as "up" and "down" in the > > history file. > > Dropping commands such as up / down could be pretty annoying if you > wanted to figure out where you were in the past. Dropping things like > bt from the history would be less annoying. I guess it's a question of preference, then. I know that my shell merges all duplicate commands into one when it comes to the history, and I really appreciate that feature. A Lot. > I wonder if we should classify commands into navigation or > state-changing commands and diagnostic commands. > I'd be happier see repeated diagnostic commands disappear, and less so > for commands that change inferior state, or navigate me around the > stack. FWIW, I'd find that distinction a little too complex for the gains we're trying to achieve. At most, I'd just suggest one toggle to activate duplicate merging or not. Just my 2 cents. -- Joel