From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Aleksandar Ristovski <ARistovski@qnx.com>
Subject: [PATCH v6 00/10] Validate binary before use
Date: Sun, 07 Jun 2015 20:04:00 -0000 [thread overview]
Message-ID: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> (raw)
Hi,
git://sourceware.org/git/archer.git
jankratochvil/gdbserverbuildid
an update. Patch below is an overall v5->v6 diff of the whole series.
That gdb_regex* move is questionable. linux_find_memory_regions_full() uses
regex now. build-id reporting needs to read+parse /proc/PID/maps so it uses
linux_find_memory_regions_full(). But the regex is used only for detecing
anonymous memory which is used for the build-id reporting (to skip trying to
read build-id from anonymous mappings) but it is not too much important. OTOH
I do not think it matters too much that a bit more code is moved to common/ .
Except for 2 (or 3 - testcase?) patches it was approved a year ago by Tom
Tromey modulo some trunk changes.
Jan
v6
* move also gdb_regex* to common/ as discussed above, also in config*.ac
* skip_to_space{,_const}() were moved to common/
* common/common-defs.h #include reordering
* new passing of enum filterflags from linux_qxfer_libraries_svr4()
* dropped refactoring of code moved to common/ that avoided GDB exceptions
* new svr4_copy_library_list() needs to handle new so_list->build_id
v5
* svr4_validate() considers missing local build-id as not-a-match
* target_so_ops->validate() now returns not-a-match reason as a string
* rename common/common-target.[ch] -> common/target-utils.[ch]
* testcase runs (but broken) even on different-filesystem remote target
* testcase simplified by using with_test_prefix()
v4
* NEWS, doc/gdb.texinfo additions.
* Used host-defs.h.
* New set/show solib-build-id-force.
* testsuite: Do not run on non-localhost remote targets.
v3
[patchv3 0/8] Validate binary before use
https://sourceware.org/ml/gdb-patches/2014-02/msg00842.html
Message-ID: <20140227213229.GA21121@host2.jankratochvil.net>
* Implemented the review comments I made.
* Removed fetching build-id in solib-svr4.c for NAT run.
v2
[PATCH 0/8] v2 - validate binary before use
https://sourceware.org/ml/gdb-patches/2013-04/msg00472.html
Message-ID: <1366127096-5744-1-git-send-email-ARistovski@qnx.com>
---
gdb/Makefile.in | 21 +
gdb/NEWS | 12 +
gdb/cli/cli-utils.c | 36 --
gdb/cli/cli-utils.h | 18 -
gdb/common/common-defs.h | 2
gdb/common/common-utils.c | 137 ++++++
gdb/common/common-utils.h | 20 +
gdb/common/common.m4 | 29 +
gdb/common/gdb_regex.c | 73 +++
gdb/common/gdb_regex.h | 36 ++
gdb/common/host-defs.h | 21 +
gdb/common/linux-maps.c | 546 +++++++++++++++++++++++
gdb/common/linux-maps.h | 64 +++
gdb/common/target-utils.c | 106 ++++
gdb/common/target-utils.h | 33 +
gdb/config/i386/linux.mh | 2
gdb/config/i386/linux64.mh | 2
gdb/configure | 102 ++--
gdb/configure.ac | 29 -
gdb/defs.h | 19 -
gdb/doc/gdb.texinfo | 55 ++
gdb/features/library-list-svr4.dtd | 13 -
gdb/gdb_regex.h | 36 --
gdb/gdbserver/Makefile.in | 12 -
gdb/gdbserver/config.in | 3
gdb/gdbserver/configure | 56 ++
gdb/gdbserver/configure.srv | 2
gdb/gdbserver/gdbreplay.c | 6
gdb/gdbserver/linux-low.c | 398 +++++++++++++++--
gdb/linux-tdep.c | 568 ++----------------------
gdb/monitor.c | 16 -
gdb/solib-darwin.c | 1
gdb/solib-dsbt.c | 1
gdb/solib-frv.c | 1
gdb/solib-spu.c | 1
gdb/solib-svr4.c | 91 ++++
gdb/solib-target.c | 2
gdb/solib.c | 62 +++
gdb/solib.h | 4
gdb/solist.h | 21 +
gdb/target.c | 94 +---
gdb/testsuite/gdb.base/solib-mismatch-lib.c | 29 +
gdb/testsuite/gdb.base/solib-mismatch-libmod.c | 29 +
gdb/testsuite/gdb.base/solib-mismatch.c | 56 ++
gdb/testsuite/gdb.base/solib-mismatch.exp | 156 +++++++
gdb/utils.c | 154 -------
gdb/utils.h | 2
47 files changed, 2165 insertions(+), 1012 deletions(-)
create mode 100644 gdb/common/gdb_regex.c
create mode 100644 gdb/common/gdb_regex.h
create mode 100644 gdb/common/linux-maps.c
create mode 100644 gdb/common/linux-maps.h
create mode 100644 gdb/common/target-utils.c
create mode 100644 gdb/common/target-utils.h
delete mode 100644 gdb/gdb_regex.h
create mode 100644 gdb/testsuite/gdb.base/solib-mismatch-lib.c
create mode 100644 gdb/testsuite/gdb.base/solib-mismatch-libmod.c
create mode 100644 gdb/testsuite/gdb.base/solib-mismatch.c
create mode 100644 gdb/testsuite/gdb.base/solib-mismatch.exp
next reply other threads:[~2015-06-07 20:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 20:04 Jan Kratochvil [this message]
2015-06-07 20:04 ` [PATCH v6 03/10] Code cleanup: Rename enum -> enum filterflags Jan Kratochvil
2015-06-08 2:39 ` Sergio Durigan Junior
2015-06-07 20:04 ` [PATCH v6 02/10] Merge multiple hex conversions Jan Kratochvil
2015-06-07 20:04 ` [PATCH v6 01/10] Move utility functions to common/ Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2015-06-08 8:37 ` Gary Benson
2015-06-11 18:48 ` Jan Kratochvil
2015-06-11 19:47 ` Aleksandar Ristovski
2015-06-12 11:26 ` Gary Benson
2015-06-14 19:28 ` Jan Kratochvil
2015-06-23 8:42 ` Gary Benson
2015-07-15 21:20 ` [PATCH v10 " Jan Kratochvil
2015-07-16 8:14 ` Gary Benson
2015-07-16 8:32 ` Jan Kratochvil
2015-07-21 10:28 ` Pedro Alves
2015-07-17 20:51 ` [PATCH v11 " Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 09/10] Validate symbol file using build-id Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 08/10] gdbserver build-id attribute generator Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 07/10] Move linux_find_memory_regions_full & co Jan Kratochvil
2015-06-08 8:42 ` Gary Benson
2015-06-07 20:05 ` [PATCH v6 10/10] Tests for validate symbol file using build-id Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 06/10] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 05/10] Move gdb_regex* to common/ Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607200422.8918.48900.stgit@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=ARistovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).