From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48078 invoked by alias); 8 Jun 2015 08:37:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48012 invoked by uid 89); 8 Jun 2015 08:37:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Jun 2015 08:37:37 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BA88D8EA5F; Mon, 8 Jun 2015 08:37:35 +0000 (UTC) Received: from blade.nx (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t588bYPX021298; Mon, 8 Jun 2015 04:37:35 -0400 Received: by blade.nx (Postfix, from userid 1000) id F29E42626FA; Mon, 8 Jun 2015 09:37:33 +0100 (BST) Date: Mon, 08 Jun 2015 08:37:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Message-ID: <20150608083733.GA5405@blade.nx> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200454.8918.52868.stgit@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150607200454.8918.52868.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00108.txt.bz2 Jan Kratochvil wrote: > prepare new files for later move. > > Approved by: > https://sourceware.org/ml/gdb-patches/2014-05/msg00367.html Like Tom, I too find it weird having a commit that creates empty files. I'd prefer to see the new files created fully populated. A bunch of stuff has changed in the way common code is laid out since May 2014, so while Tom approved this back then, it's not suitable any more. Please update the series as follows: > * common/linux-maps.c: New file. > * common/linux-maps.h: New file. Nothing os-specific should be in common. These files should be nat/linux-maps.[ch]. > * common/target-utils.c: New file. > * common/target-utils.h: New file. Nothing to do with the target should be in common. The declarations should probably be in target/target.h, and they should have "target_" prefixes. You could create target/target.c to put the definitions in. > diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c ... > + > +#ifdef GDBSERVER > +#include "server.h" > +#else > +#include "defs.h" > +#endif > + > +#include "linux-maps.h" This should be: #include "common-defs.h" #include "linux-maps.h" Please read this: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files Other new files in this patch need similar treatment. On a separate but related note, please do not add GDBSERVER conditionals anywhere, I spent half a year removing almost all of them and the remaining couple are on my hit list. Thanks, Gary -- http://gbenson.net/