From: Gary Benson <gbenson@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: ping: [patch] gdbserver <library-list> and its #FIXED version="1.0"
Date: Mon, 08 Jun 2015 09:08:00 -0000 [thread overview]
Message-ID: <20150608090756.GA5989@blade.nx> (raw)
In-Reply-To: <20150607141054.GA21633@host1.jankratochvil.net>
Jan Kratochvil wrote:
> this patch was never replied:
> [patch] gdbserver <library-list> and its #FIXED version="1.0"
> https://sourceware.org/ml/gdb-patches/2011-11/msg00099.html
> Message-ID: <20111103191640.GA27298@host1.jankratochvil.net>
>
> but in this patch Tom Tromey has IIUC approved it:
> Re: [PATCH v5 6/8] gdbserver build-id attribute generator
> https://sourceware.org/ml/gdb-patches/2014-05/msg00490.html
> Message-ID: <87lhtvm634.fsf@fleche.redhat.com>
>
> I guess I should check it in the first referenced patch but given all the years
> have passed and maintainers changed I am rather pinging it for a new opinion.
The "if (version)" should likely be "if (version != NULL)".
Otherwise it seems ok.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-06-08 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 19:17 Jan Kratochvil
2015-06-07 14:11 ` ping: " Jan Kratochvil
2015-06-08 9:08 ` Gary Benson [this message]
2015-06-10 16:31 ` [commit] " Jan Kratochvil
2015-06-10 17:38 ` [commit#2] " Jan Kratochvil
2015-06-10 16:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608090756.GA5989@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).