From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16817 invoked by alias); 8 Jun 2015 09:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16074 invoked by uid 89); 8 Jun 2015 09:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Jun 2015 09:07:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5C3983582B8 for ; Mon, 8 Jun 2015 09:07:58 +0000 (UTC) Received: from blade.nx (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5897vSF014023; Mon, 8 Jun 2015 05:07:57 -0400 Received: by blade.nx (Postfix, from userid 1000) id 6D3082626FA; Mon, 8 Jun 2015 10:07:56 +0100 (BST) Date: Mon, 08 Jun 2015 09:08:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: ping: [patch] gdbserver and its #FIXED version="1.0" Message-ID: <20150608090756.GA5989@blade.nx> References: <20111103191640.GA27298@host1.jankratochvil.net> <20150607141054.GA21633@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150607141054.GA21633@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00111.txt.bz2 Jan Kratochvil wrote: > this patch was never replied: > [patch] gdbserver and its #FIXED version="1.0" > https://sourceware.org/ml/gdb-patches/2011-11/msg00099.html > Message-ID: <20111103191640.GA27298@host1.jankratochvil.net> > > but in this patch Tom Tromey has IIUC approved it: > Re: [PATCH v5 6/8] gdbserver build-id attribute generator > https://sourceware.org/ml/gdb-patches/2014-05/msg00490.html > Message-ID: <87lhtvm634.fsf@fleche.redhat.com> > > I guess I should check it in the first referenced patch but given all the years > have passed and maintainers changed I am rather pinging it for a new opinion. The "if (version)" should likely be "if (version != NULL)". Otherwise it seems ok. Cheers, Gary -- http://gbenson.net/