* [PATCH] Fix preprocessor conditional
@ 2015-06-09 9:21 Gary Benson
2015-06-09 12:24 ` Gary Benson
0 siblings, 1 reply; 2+ messages in thread
From: Gary Benson @ 2015-06-09 9:21 UTC (permalink / raw)
To: gdb-patches
Hi all,
This commit fixes a typo in common/fileio.c where S_IWGRP was
misspelled as S_IWRGRP in a preprocessor conditional, causing
Host-I/O "vFile:fstat:" and File-I/O "Fstat" and "Ffstat"
responses to always indicate files were not group-writable
regardless of their actual status.
Pushed as obvious.
Thanks,
Gary
---
gdb/ChangeLog | 5 +++++
gdb/common/fileio.c | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gdb/common/fileio.c b/gdb/common/fileio.c
index 28335ec..ef00ea8 100644
--- a/gdb/common/fileio.c
+++ b/gdb/common/fileio.c
@@ -132,7 +132,7 @@ fileio_mode_pack (mode_t mode)
if (mode & S_IRGRP)
tmode |= FILEIO_S_IRGRP;
#endif
-#ifdef S_IWRGRP
+#ifdef S_IWGRP
if (mode & S_IWGRP)
tmode |= FILEIO_S_IWGRP;
#endif
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix preprocessor conditional
2015-06-09 9:21 [PATCH] Fix preprocessor conditional Gary Benson
@ 2015-06-09 12:24 ` Gary Benson
0 siblings, 0 replies; 2+ messages in thread
From: Gary Benson @ 2015-06-09 12:24 UTC (permalink / raw)
To: gdb-patches
This commit does have a ChangeLog entry; for some reason the
script I'm using didn't pick it up for the commit message :(
Gary Benson wrote:
> Hi all,
>
> This commit fixes a typo in common/fileio.c where S_IWGRP was
> misspelled as S_IWRGRP in a preprocessor conditional, causing
> Host-I/O "vFile:fstat:" and File-I/O "Fstat" and "Ffstat"
> responses to always indicate files were not group-writable
> regardless of their actual status.
>
> Pushed as obvious.
>
> Thanks,
> Gary
>
> ---
> gdb/ChangeLog | 5 +++++
> gdb/common/fileio.c | 2 +-
> 2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/common/fileio.c b/gdb/common/fileio.c
> index 28335ec..ef00ea8 100644
> --- a/gdb/common/fileio.c
> +++ b/gdb/common/fileio.c
> @@ -132,7 +132,7 @@ fileio_mode_pack (mode_t mode)
> if (mode & S_IRGRP)
> tmode |= FILEIO_S_IRGRP;
> #endif
> -#ifdef S_IWRGRP
> +#ifdef S_IWGRP
> if (mode & S_IWGRP)
> tmode |= FILEIO_S_IWGRP;
> #endif
> --
> 1.7.1
--
http://gbenson.net/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-09 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-09 9:21 [PATCH] Fix preprocessor conditional Gary Benson
2015-06-09 12:24 ` Gary Benson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).