From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42152 invoked by alias); 15 Jun 2015 13:22:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42142 invoked by uid 89); 15 Jun 2015 13:22:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Jun 2015 13:22:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 43B7528DEB; Mon, 15 Jun 2015 09:22:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6rBxBcyrSYhr; Mon, 15 Jun 2015 09:22:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1DCA9289A0; Mon, 15 Jun 2015 09:22:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 99DF3406D9; Mon, 15 Jun 2015 06:22:50 -0700 (PDT) Date: Mon, 15 Jun 2015 13:22:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v7 01/10] Move utility functions to common/ Message-ID: <20150615132250.GB25717@adacore.com> References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192551.18346.67512.stgit@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150614192551.18346.67512.stgit@host1.jankratochvil.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00302.txt.bz2 > gdb/ChangeLog > 2014-02-26 Aleksandar Ristovski Jan Kratochvil > > Move utility functions to common/. > * cli/cli-utils.c (skip_spaces, skip_spaces_const, skip_to_space_const): > Move defs to common/common-utils.c. > * cli/cli-utils.h (skip_spaces, skip_spaces_const, skip_to_space) > (skip_to_space_const): Move decls to common/common-utils.h. > * common/common-defs.h: Move include of common-types.h before > common-utils.h. > * common/common-utils.c: Include host-defs.h and ctype.h. > (HIGH_BYTE_POSN, is_digit_in_base, digit_to_int, strtoulst): Move > from utils.c. > (skip_spaces, skip_spaces_const, skip_to_space_const): Move from > cli/cli-utils.c. > * common/common-utils.h (strtoulst): Move decl from utils.h. > (skip_spaces, skip_spaces_const, skip_to_space, skip_to_space_const): > Move from cli/cli-utils.h. > * common/host-defs.h: Include limits.h. > (TARGET_CHAR_BIT, HOST_CHAR_BIT): Moved from defs.h. > (skip_spaces, skip_spaces_const): Move decls from cli/cli-utils.h. > * defs.h (TARGET_CHAR_BIT, HOST_CHAR_BIT): Move to > common/common-utils.h. > * utils.c (HIGH_BYTE_POSN, is_digit_in_base, digit_to_int) > (strtoulst): Move to common/common-utils.c. > * utils.h (strtoulst): Moved decl to common/common-utils.h. This one looks pretty straightfoward and useful, so OK. I *think* from reading through the patch that some of the functions being moved don't have documentation. This is not for this patch, but if you wouldn't mind, would you use this opportunity to add that documentation as a followup patch? If you don't have the time, then no problem, but do let me know so I can go in and do that. Thanks, -- Joel