Re: [PATCH] gdb: microblaze: delete useless stubs

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

On 21 Jun 2015 12:36, Michael Eager wrote:
> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
> > These don't accomplish anything the common core doesn't already, so
> > punt them as they purely waste code.
> >
> > 2015-06-21  Mike Frysinger  <vapier@gentoo.org>
> >
> > 	* microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> > 	(microblaze_push_dummy_call): Likewise.
> > 	(microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> > 	and set_gdbarch_push_dummy_call.
> 
> Does the common code issue an error if someone tries
> to call a target function?

yes

gdb/infcall.c:
struct value *
call_function_by_hand_dummy (struct value *function,
...
  if (!gdbarch_push_dummy_call_p (gdbarch))
    error (_("This target does not support function calls."));

$ ./gdb ...
(gdb) p foo(1)
This target does not support function calls.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]