From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109039 invoked by alias); 25 Jun 2015 11:21:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109025 invoked by uid 89); 25 Jun 2015 11:21:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Jun 2015 11:21:20 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id A5BB0340961; Thu, 25 Jun 2015 11:21:18 +0000 (UTC) Date: Thu, 25 Jun 2015 11:21:00 -0000 From: Mike Frysinger To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: tests: mark async unsupported dynamically Message-ID: <20150625112117.GR17734@vapier> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <1434770234-24916-1-git-send-email-vapier@gentoo.org> <558A93BA.4030205@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CPn8Wy5ME997YUMW" Content-Disposition: inline In-Reply-To: <558A93BA.4030205@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00546.txt.bz2 --CPn8Wy5ME997YUMW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1575 On 24 Jun 2015 12:25, Pedro Alves wrote: > On 06/20/2015 04:17 AM, Mike Frysinger wrote: > > There are many targets which do not support asynchronous execution. > > Rather than having the async tests mark them as FAIL, use UNSUPPORTED > > as that better represents the state. > > --- > > 2015-06-19 Mike Frysinger > >=20 > > * gdb.base/async.exp (test_background): Call unsupported when async > > isn't supported. > >=20 > > gdb/testsuite/gdb.base/async.exp | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/= async.exp > > index 2d3fb73..4b9168a 100644 > > --- a/gdb/testsuite/gdb.base/async.exp > > +++ b/gdb/testsuite/gdb.base/async.exp > > @@ -58,6 +58,9 @@ proc test_background {command before_prompt after_pro= mpt {message ""}} { > > -re "^$command\r\n${before_prompt}${gdb_prompt}${after_prompt}complet= ed\.\r\n" { > > pass "$message" > > } > > + -re "Asynchronous execution not supported on this target\.\r\n" { > > + unsupported "$message" > > + } > > -re "$gdb_prompt.*completed\.\r\n" { > > fail "$message" > > } > >=20 >=20 > We should also return something that the caller checks to bail the > rest of the file. Otherwise, as soon as we add something to the > test that expects that e.g., "print foo" returns some value after the > previous async commands worked, that test will fail on sync targets. returning an error on unsupported makes sense. but if we fail in general, = don't=20 want to run all tests and such still ? -mike --CPn8Wy5ME997YUMW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVi+QtAAoJEEFjO5/oN/WB52oQALcALXx8Tn1E5wEQElqTdwRj RNHPJLSYT+ZObhiX0Lq3a4qPz+uIiDQBoWiZf9oESFJgmZrVw9FFClay0MREa3Zm DnVhPQ62B0nJju0yx9mjDAF0rozyXGvgA92PeUtlTPQ6OJ02XF3j+ND5/ICDQGY5 19g+DyUD88gQ33txWuyVA3L1SaH8Zawwd7BD6PEQtsouc+JwGMeJTb75xhVgt12N euuhfR9EQ7vdvzMYJIg95MPvssmGeBvmGHVErzWHJlWYdP2Zwo0/93e761da0yh4 ZYlsBqIzFDdgCqkpq7sp0sw9ciikNxsKQ8yXCeYMumus07jZNWy+IPhaK/My5SrJ e0iIXXJyAfm+DlPt0Tc5Muc7W65bthoadCCwNQl4gjCy+GrfVHPOuJ9UMlu/kAaC jR0mpe0U9RxtXAtTjQ3ELSW+sFeLylz1iL/Q8HVUFivPeGBO1PCJMvgBmtBF1Ryq BgA8WPItDASkKcYd6QttIno1p2U+E/bY2psbrAKHzOzlJ/V9Hj7BwxjJtSF5GYHL WE5Vw7aGp7LY9OicFPB+uqXUCQx9ypYNmlrir0F4ZZHHjNq3EJMpsqrbMh4ONjYA L8s5mhppKFx4XnH+3l8ypcYDKN/gQg+hr5p+OBnnaeJMQGL7R+RlhIS9bj6Tk+re I8hJWsMyVtBFApZUfVsa =trZF -----END PGP SIGNATURE----- --CPn8Wy5ME997YUMW--