From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files
Date: Fri, 10 Jul 2015 11:47:00 -0000 [thread overview]
Message-ID: <20150710114743.GA12225@host1.jankratochvil.net> (raw)
In-Reply-To: <86lheol7wz.fsf@gmail.com>
On Fri, 10 Jul 2015 10:43:24 +0200, Yao Qi wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> > * gdb.asm/asm-source.exp (f at main): Stop at gdbasm_enter.
> > (n at main): New.
> > * gdb.asm/asmsrc1.s: Add comment "mark: main enter".
>
> What does "f at main" and "n at main" in parenthesises mean here?
Names of the testcases involved, it was always written this way for whatever
reason, unless it has changed:
+gdb_test "f" "asmsrc1\[.\]s:$line_enter.*gdbasm_enter" "f at main"
+
+# Execute the `n' command.
+gdb_test "n" "$line_main\[ \]*.*several_nops" "n at main"
So I guess it is still OK for check-in with this ChangeLog.
Thanks,
Jan
next prev parent reply other threads:[~2015-07-10 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 16:37 Jan Kratochvil
2015-07-10 8:43 ` Yao Qi
2015-07-10 11:47 ` Jan Kratochvil [this message]
2015-07-10 14:32 ` Yao Qi
2015-07-10 14:49 ` Jan Kratochvil
2015-07-10 13:07 ` [testsuite commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710114743.GA12225@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).