public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files
Date: Fri, 10 Jul 2015 14:49:00 -0000	[thread overview]
Message-ID: <20150710144856.GA2659@host1.jankratochvil.net> (raw)
In-Reply-To: <868uaokrqw.fsf@gmail.com>

On Fri, 10 Jul 2015 16:32:39 +0200, Yao Qi wrote:
> I don't know such convention of writing changelog entry for .exp changes.
> We usually put the proc or variable name into the parenthesis, like,
> 
>         * gdb.foo/bar.exp (proc_name): XXXX

That also happenes/ed.


> Is it documented somewhere?

I do not know, in GDB I always follow past practices (which are not always
good):
2011-05-20  Pierre Muller  <muller@ics.u-strasbg.fr>
[...]
        * gdb.base/default.exp (show convenience): Use double
	                        ^^^^^^^^^^^^^^^^
        quote pattern for regular expressions.
[...]
2011-01-09  Andreas Schwab  <schwab@linux-m68k.org>

        * gdb.threads/tls.exp ("info address me"): Fix expected output.
	                        ^^^^^^^^^^^^^^^

Somehow I think the intention of the ChangeLog entries is to identify where
the change happened, so both test case name or subroutine name is appropriate,
depending on what matches better.  At least I saw it so before.


Jan

  reply	other threads:[~2015-07-10 14:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 16:37 Jan Kratochvil
2015-07-10  8:43 ` Yao Qi
2015-07-10 11:47   ` Jan Kratochvil
2015-07-10 14:32     ` Yao Qi
2015-07-10 14:49       ` Jan Kratochvil [this message]
2015-07-10 13:07   ` [testsuite commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710144856.GA2659@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).