From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44914 invoked by alias); 10 Jul 2015 14:49:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44886 invoked by uid 89); 10 Jul 2015 14:49:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Jul 2015 14:49:02 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 07CCA388B75; Fri, 10 Jul 2015 14:49:01 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6AEmv90031893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 10 Jul 2015 10:49:00 -0400 Date: Fri, 10 Jul 2015 14:49:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files Message-ID: <20150710144856.GA2659@host1.jankratochvil.net> References: <20150629163708.GA28795@host1.jankratochvil.net> <86lheol7wz.fsf@gmail.com> <20150710114743.GA12225@host1.jankratochvil.net> <868uaokrqw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <868uaokrqw.fsf@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00326.txt.bz2 On Fri, 10 Jul 2015 16:32:39 +0200, Yao Qi wrote: > I don't know such convention of writing changelog entry for .exp changes. > We usually put the proc or variable name into the parenthesis, like, > > * gdb.foo/bar.exp (proc_name): XXXX That also happenes/ed. > Is it documented somewhere? I do not know, in GDB I always follow past practices (which are not always good): 2011-05-20 Pierre Muller [...] * gdb.base/default.exp (show convenience): Use double ^^^^^^^^^^^^^^^^ quote pattern for regular expressions. [...] 2011-01-09 Andreas Schwab * gdb.threads/tls.exp ("info address me"): Fix expected output. ^^^^^^^^^^^^^^^ Somehow I think the intention of the ChangeLog entries is to identify where the change happened, so both test case name or subroutine name is appropriate, depending on what matches better. At least I saw it so before. Jan