From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27244 invoked by alias); 12 Jul 2015 19:09:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27235 invoked by uid 89); 12 Jul 2015 19:09:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 12 Jul 2015 19:09:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C14BA91E8E; Sun, 12 Jul 2015 19:09:26 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6CJ9MhP016879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 12 Jul 2015 15:09:24 -0400 Date: Sun, 12 Jul 2015 19:09:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Doug Evans , gdb-patches , Aleksandar Ristovski Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id Message-ID: <20150712190921.GA8682@host1.jankratochvil.net> References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192655.18346.17075.stgit@host1.jankratochvil.net> <20150621101644.GA12733@host1.jankratochvil.net> <20150623204702.GA2156@host1.jankratochvil.net> <559D3749.9010200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559D3749.9010200@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00354.txt.bz2 On Wed, 08 Jul 2015 16:44:25 +0200, Pedro Alves wrote: > Jan Kratochvil wrote: > > > +static char * > > +svr4_validate (const struct so_list *const so) > > +{ > > ... > > > + return xstrprintf (_("remote build ID is %s " > > + "but local file does not have build ID"), > > + remote_hex); > > Seems odd to say "remote" here. Can't these errors trigger with native > debugging as well? For this patchset not yet. The message is changed in a later patchset being prepared where it applies also for local files. > Doug Evans wrote: > > > >> > If so, having solib in the option name is confusing. > >> > > >> > set build-id-force > >> > or > >> > set require-build-id-match > >> > or some such would be clearer. > > "build-id-force" sound odd to me. The latter sounds OK, > as would "set build-id-validation on/off/...". OK, I will change it to "set build-id-validation on/off/...". > With that, and once the previous issues raised are > addressed, I think this is good to go. There patches are left without reply: [PATCH v7 04/10] Create empty nat/linux-maps.[ch] and common/target-utils.[ch] [PATCH v7 06/10] Prepare linux_find_memory_regions_full & co. for move [PATCH v7 07/10] Move linux_find_memory_regions_full & co. There particularly the [PATCH v7 06/10] contains non-mechanical (a bit) changes. Thanks, Jan