From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65504 invoked by alias); 12 Jul 2015 19:27:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65494 invoked by uid 89); 12 Jul 2015 19:27:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 12 Jul 2015 19:27:36 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 50D35A1019; Sun, 12 Jul 2015 19:27:35 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6CJRV4p026565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 12 Jul 2015 15:27:33 -0400 Date: Sun, 12 Jul 2015 19:27:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches , Aleksandar Ristovski Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id Message-ID: <20150712192730.GA12553@host1.jankratochvil.net> References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192655.18346.17075.stgit@host1.jankratochvil.net> <20150621101644.GA12733@host1.jankratochvil.net> <20150627210519.GA19048@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00355.txt.bz2 On Wed, 08 Jul 2015 17:39:14 +0200, Doug Evans wrote: > On Sat, Jun 27, 2015 at 4:05 PM, Jan Kratochvil > wrote: > >> > ... This is actual > >> > + BUILD_ID which comes either from the remote target via qXfer > >> > + packet or via reading target memory. Therefore, it may differ > >> > + from the build-id of the associated bfd. In a normal > >> > + scenario, this so would soon lose its abfd due to failed > >> > + validation. > >> > >> I can't read this last sentence. > >> What are you trying to say here? > > > > It was written by Aleksandar Ristovski and I find it OK myself. > > So as an explanation the process is: > > > > 1. GDB reads/receives so->build_id from GDB server. > > 2. GDB opens local BFD so->abfd. > > 3. GDB compares so->build_id with so->abfd->build_id (by ops->validate) > > 4. If they differ so->abfd is freed/cleared (in solib_map_sections). > > > > Therefore could you suggest a different comment? > > I'd be ok with just deleting the last two sentences: > > This is actual > BUILD_ID which comes either from the remote target via qXfer > packet or via reading target memory. > > But if you want more I'm ok with: > > This is actual > BUILD_ID which comes either from the remote target via qXfer > packet or via reading target memory. Note that if there's a > mismatch with the associated bfd then so->abfd will be cleared. Used the latter one. Thanks, Jan