From: Gary Benson <gbenson@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Use debug_printf to print debug message
Date: Tue, 14 Jul 2015 14:02:00 -0000 [thread overview]
Message-ID: <20150714140220.GA26999@blade.nx> (raw)
In-Reply-To: <1436282578-8070-3-git-send-email-yao.qi@linaro.org>
Yao Qi wrote:
> Some functions in aarch64-linux-nat.c and linux-aarch64-low.c looks
> the same except for the code printing debug message. In GDB, we use
> fprintf_unfiltered (gdb_stdlog, ...) while in GDBserver, we use
> fprintf (stderr, ...). This patch is to change them to use
> debug_printf so that these functions are the same, and I can move
> them to a common place in the following patch.
...
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 94093fc..869edda 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -426,30 +426,28 @@ aarch64_show_debug_reg_state (struct aarch64_debug_reg_state *state,
> {
> int i;
>
> - fprintf_unfiltered (gdb_stdlog, "%s", func);
> + debug_printf ( "%s", func);
Just this one problem, an extra whitespace after the paren.
Otherwise looks good.
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-07-14 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 15:23 [PATCH 0/4] Move common aarch64 HW breakpoint/watchpoint code to nat/ Yao Qi
2015-07-07 15:23 ` [PATCH 1/4] int -> enum target_hw_bp_type in aarch64-linux-nat.c Yao Qi
2015-07-07 15:23 ` [PATCH 2/4] Use debug_printf to print debug message Yao Qi
2015-07-14 14:02 ` Gary Benson [this message]
2015-07-07 15:23 ` [PATCH 4/4] Move common aarch64 HW breakpoint/watchpoint code to nat/ Yao Qi
2015-07-07 15:23 ` [PATCH 3/4] Pass aarch64_debug_reg_state to functions Yao Qi
2015-07-14 14:05 ` [PATCH 0/4] Move common aarch64 HW breakpoint/watchpoint code to nat/ Gary Benson
2015-07-17 13:36 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714140220.GA26999@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).