From: Gary Benson <gbenson@redhat.com>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix build issue due to Introduce nat/linux-namespaces.[ch] patch
Date: Wed, 15 Jul 2015 12:32:00 -0000 [thread overview]
Message-ID: <20150715123241.GA17602@blade.nx> (raw)
In-Reply-To: <1436888999.5245.4.camel@otta>
Peter Bergner wrote:
> On Tue, 2015-07-14 at 15:46 +0100, Gary Benson wrote:
> > I'd prefer it without the nested conditionals:
> >
> > #ifdef HAVE_SETNS
> > return setns (fd, nstype);
> > #elif defined __NR_setns
> > return syscall (__NR_setns, fd, nstype);
> > #else
> > errno = ENOSYS;
> > return -1;
> > #endif
> >
> > Otherwise ok. Thanks for doing this work!
>
> Hmmm, for some reason I thought #elif wasn't supported, since I
> agree this looks better. Maybe I was thinking of some scripting
> language limitation? Anyway, I committed the patch with your
> suggested change. Thanks!
Thank you :)
Cheers,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2015-07-15 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 20:36 Peter Bergner
2015-07-14 14:46 ` Gary Benson
2015-07-14 15:50 ` Peter Bergner
2015-07-15 12:32 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715123241.GA17602@blade.nx \
--to=gbenson@redhat.com \
--cc=bergner@vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).