From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72246 invoked by alias); 15 Jul 2015 12:32:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72232 invoked by uid 89); 15 Jul 2015 12:32:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Jul 2015 12:32:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D69B32D4519; Wed, 15 Jul 2015 12:32:42 +0000 (UTC) Received: from blade.nx (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6FCWgUD015365; Wed, 15 Jul 2015 08:32:42 -0400 Received: by blade.nx (Postfix, from userid 1000) id 9FC662642A3; Wed, 15 Jul 2015 13:32:41 +0100 (BST) Date: Wed, 15 Jul 2015 12:32:00 -0000 From: Gary Benson To: Peter Bergner Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix build issue due to Introduce nat/linux-namespaces.[ch] patch Message-ID: <20150715123241.GA17602@blade.nx> References: <1436474110.5367.27.camel@otta> <20150714144641.GC26999@blade.nx> <1436888999.5245.4.camel@otta> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436888999.5245.4.camel@otta> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00432.txt.bz2 Peter Bergner wrote: > On Tue, 2015-07-14 at 15:46 +0100, Gary Benson wrote: > > I'd prefer it without the nested conditionals: > > > > #ifdef HAVE_SETNS > > return setns (fd, nstype); > > #elif defined __NR_setns > > return syscall (__NR_setns, fd, nstype); > > #else > > errno = ENOSYS; > > return -1; > > #endif > > > > Otherwise ok. Thanks for doing this work! > > Hmmm, for some reason I thought #elif wasn't supported, since I > agree this looks better. Maybe I was thinking of some scripting > language limitation? Anyway, I committed the patch with your > suggested change. Thanks! Thank you :) Cheers, Gary -- http://gbenson.net/